Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging development into the main branch #79

Merged
merged 25 commits into from
Jan 21, 2020
Merged

Merging development into the main branch #79

merged 25 commits into from
Jan 21, 2020

Conversation

arkhometha
Copy link
Owner

Changelog so far:

  • Fix for warship commission messing with naval base levels
  • Added a missing vassal transfer event for the new CB.
  • Fixed a few NNM Korean events that could still happen if one of the countries was a puppet.
  • Decreased the costs for construction the canals - Suez was halved, while Panama should cost double what the Suez costed, in average. Kiel also got reduced. Prestige gain for Suez was increased from 20 to 40 and Panama from 50 to 75. Keep in mind these are still gigantic works, so they should cost a lot of money and should put a dent even in a Great Power economy.
  • Added the steal_puppet CB to the peace order by @moretrim (Add steal_puppet to the peace order #60)
  • Removing redundant sphere checks and guaranteeing wars are not cancelled by sphering. Largely based in work by @moretrim (Clean up sphere requirements on CBs #61)
  • Added localization to the inventions that were missing it. Luxury Clothes factories should now be unlocked with Jacquard Loom, since that was the invention that enabled it. Fixes [BUG] No localization text for luxury factory inventions #59
  • Overall balance of production and base profits for factories and artisans. Addressing the issues raised in [BUG] Artisan discrepancies #66
  • Added localized names for a few places in the low countries, addressing Use Dutch/Flemish province names in Flanders #62
  • Belgian parties fixed by @halcyon-gh - French names for Belgian political parties #64
  • Updated Child Labor icon and a few new rivers to Brazil by @thiagodesacosta - Update gfx child labor and some rivers in Brazil #75
  • Armenian pops changed to Coptic religion. By @Libeccio-DD - Religion of Armenian pops #71
  • Renamed Coptic religion to Oriental Orthodox and the Orthodox religion to Eastern Orthodox.
  • Muslim countries should now start with the Pact of Umar, which will stop conversion of non-muslim pops, slow assimilation and levy some money. This can be repealed through a decision. Secularizing the society will have the same effect with none of the negative consequences.
  • Fixes for the country ghost units system where it could lead to a consistent crash when clicking in the diplomacy tab. This fix adds a delay to the system, so ghost units can take up to 3 months to disappear (but they will disappear). Fix for [BUG] Game crash always around end of 1885 #73
  • Tweaks for the Serf-cleanup routines so it happens less often, leading to less false positives.
  • Tweak China coal mines to flip later in the game, to stop overproduction of coal early-game.
  • Fixed a few wrong references to coal in inventions that boost iron production.
  • Increased Bessemer Steel bonus to iron production.
  • Added a decision to found the Niger Company for any country that owns a province in southern Nigeria. The decision will help model how colonization of the area went ahead.
  • Removed a few of Shewa's cores to avoid them forming Ethiopia every time.
  • Fixed a bug related to the order debts were accrued. The bug made it so every debt acquired through the debt system was doubled. Sorry about that.
  • Added the debt system to the Exploration events (North and South pole, Source of the Nile). Mainly to a void the AI bankrupting itself, which it still did. Increased monetary cost of events so taking it isn't always the no-brainer it was. Improved AI logic for picking up options so they put up more competition to the player in these events.
  • Made the southern-german minor states allied to each other and to Austria. Saxony is the exception, but they will start allied to Austria.

arkhometha and others added 25 commits December 31, 2019 17:22
CB `steal_puppet` was missing from the peace order list, which could
result in unintended results in a peace deal involving multiple CBs.

The CB is placed in-between the CBs that release a vassal and the CBs
that vassalise a country. This seems appropriate as in some sense
`steal_puppet` does those two things in succession.
Change the mixed Dutch/English names to French except for the Flemish Meetingpartij. Change the reactionary party to 'Parti Statiste' which was the conservative faction in the Brabantian revolution of 1790.
* Added a missing vassal transfer event for the new CB.
* Fixed a few NNM Korean events that could still happen if one of the countries was a puppet.
* Decreased the costs for construction the canals - Suez was halved, while Panama should cost double what the Suez costed, in average. Kiel also got reduced. Prestige gain for Suez was icnreased from 20 to 40 and Panama from 50 to 75. Keep in mind these are still gigantic works, so they should cost a lot of money and should put a dent even in a Great Power economy.
-Changed the religion of Armenian pops from Orthodox to Coptic
-Changed the religion of ARM and CLC from Orthodox to Coptic
* Added the steal_puppet CB to the peace order by @moretrim (#60)
* Removing redundant sphere checks and guaranteeing wars are not cancelled by sphering. Largely based in work by @moretrim (#61)
Dirty and torn teddy bear
Added Paraná river, Tiete river, Rio Grande river, Paranaiba river and others nearby. Fixed some Amazonian rivers.
* Added localization to the inventions that were missing it. Luxury Clothes factories should now be unlocked with Jacquard Loom, since that was the invention that enabled it. Fixes #59
* Overall balance of production and base profits for factories and artisans. Addressing the issues raised in #66
* Added localized names for a few places in the low countries, addressing #62
French names for Belgian political parties
Update gfx child labor and some rivers in Brazil
* Renamed Coptic religion to Oriental Orthodox and the Orthodox religion to Eastern Orthodox.
* Muslim countries should now start with the Pact of Umar, which will stop conversion of non-muslim pops, slow assimilation and levy some money. This can be repealed through a decision. Secularizing the society will have the same effect with none of the negative consequences.
…anup optimizations

* Fixes for the country ghost units system where it could lead to a consitent crash when clicking in the diplomacy tab. This fix adds a delay to the system, so ghost units can take up to 3 months to disappear (but they will disappear). Fix for #73
* Tweaks for the Serf-cleanup routines so it happens less often, leading to less false positives.
* Tweak China coal mines to flip later in the game, to stop overproduction of coal early-game.
* Fixed a few wrong references to coal in inventions that boost iron production.
* Increased Bessemer Steel bonus to iron production.
* Added a decision to found the Niger Company for any country that owns a province in southern Nigeria. The decision will help model how colonization of the area went ahead.
* Removed a few of Shewa's cores to avoid them forming Ethiopia everytime.
* Few tweaks for the ghost-country cleanup system.
* Continuing work in avoid the early-game overproduction of coal.
* Fixed a bug related to the order debts were accrued. The bug made it so every debt acquired through the debt system was doubled. Sorry about that.
* Added the debt system to the Exploration events (North and South pole, Source of the Nile). Mainly toa void the AI bankrupting itself, which it still did. Increased monetary cost of events so taking it isn't always the no-brainer it was. Improved AI logic for picking up options so they put up more competition to the player in these events.
* Made the southern-german minor states allied to each other and to Austria. Saxony is the exception, but they will start allied to Austria.
* Continuing tweaks to early game economy.
* Mainly to guarantee uncivs get the units they are going for in face of the changes the tech had because of the vanilla bug with created units being stuck in ports and the need to fix that.
* Finished a few of changes that would cause the bug with naval ports due to the fix for the aforementioned bug.
@arkhometha arkhometha merged commit d34300b into master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No localization text for luxury factory inventions
5 participants