Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] No localization text for luxury factory inventions #59

Closed
CommandoGrandma opened this issue Jan 1, 2020 · 1 comment · Fixed by #79
Closed

[BUG] No localization text for luxury factory inventions #59

CommandoGrandma opened this issue Jan 1, 2020 · 1 comment · Fixed by #79
Assignees
@arkhometha
Labels
bug Something isn't working

Comments

@CommandoGrandma
Copy link

Playing on the beta hotfix. The descriptions for the new luxury furniture and luxury clothes factory inventions are placeholder text.
@CommandoGrandma CommandoGrandma added the bug Something isn't working label Jan 1, 2020
arkhometha added a commit that referenced this issue Jan 19, 2020
@arkhometha
Missing localization, production inconsistencies
be39d4e 
* Added localization to the inventions that were missing it. Luxury Clothes factories should now be unlocked with Jacquard Loom, since that was the invention that enabled it. Fixes #59
* Overall balance of production and base profits for factories and artisans. Addressing the issues raised in #66
* Added localized names for a few places in the low countries, addressing #62
@arkhometha
Copy link
Owner

Hi @CommandoGrandma, thanks for the report. The popup for the invention shouldn't even show up, or so I thought, but anyway, this is fixed in commit be39d4e

This was referenced Jan 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkhometha arkhometha

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merging development into the main branch arkhometha/Historical-Project-Mod
2 participants
@arkhometha @CommandoGrandma