Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dutch/Flemish province names in Flanders #62

Conversation

halcyon-gh
Copy link
Contributor

This makes the province names more consistent since they are in Dutch in the Netherlands and in French in Wallonia and France.

arkhometha added a commit that referenced this pull request Jan 19, 2020
* Added localization to the inventions that were missing it. Luxury Clothes factories should now be unlocked with Jacquard Loom, since that was the invention that enabled it. Fixes #59
* Overall balance of production and base profits for factories and artisans. Addressing the issues raised in #66
* Added localized names for a few places in the low countries, addressing #62
@arkhometha
Copy link
Owner

Hi @halcyon-gh, thanks for the pull request. The way vanilla Victoria 2 names provinces is by having provinces/cities default to the English name for them. That's why a province like Livorno, in Italy, is called Leghorn in game. The same applies to the Low Countries - Charleroi isn't called "Charles the King" in English, but by their French name, so their French name is kept.
Overall, I'd like to keep this standard as it A) confusion because people will search for "Damascus" instead of Dimašq, B) consistency since everything is in English and C) the trouble that would happen if we had to change a province everytime it changed hands and the occupier spoke another language.

This rule is only broken in special cases such as places with several names, depending on the occupier (like Port Arthur) to give some flavour to these parts - it would be weird if the Japanese conquered "Port Arthur" and it was still called that. I've added your suggestions to the "localized names" start game options in commit be39d4e, so if you'd rather play with localized names for these provinces, it will be easy to do so.

@arkhometha arkhometha closed this Jan 19, 2020
@halcyon-gh halcyon-gh deleted the dev-flemish_province_names branch January 22, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants