Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomness #7: make api, indexer, fake aptos db aware of block metadata ext txns #12227

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Feb 25, 2024

Description

Test Plan

Copy link

trunk-io bot commented Feb 25, 2024

⏱️ 7h 5m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 48m 🟩🟩🟩
windows-build 1h 46m 🟩🟩🟩🟩🟩
rust-lints 32m 🟩🟩🟩
rust-smoke-tests 30m 🟩
run-tests-main-branch 29m 🟥🟥🟥🟥
execution-performance / single-node-performance 27m 🟥🟩
check 19m 🟩🟩🟩
forge-e2e-test / forge 13m 🟩
rust-images / rust-all 13m 🟩
forge-compat-test / forge 13m 🟩
check-dynamic-deps 10m 🟩🟩🟩🟩🟩
general-lints 10m 🟩🟩🟩🟩
cli-e2e-tests / run-cli-tests 9m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 58s 🟩🟩🟩🟩🟩
file_change_determinator 56s 🟩🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩
permission-check 15s 🟩🟩🟩🟩🟩
permission-check 15s 🟩🟩🟩🟩🟩
permission-check 15s 🟩🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩🟩
file_change_determinator 12s 🟩
execution-performance / file_change_determinator 12s 🟩
determine-docker-build-metadata 7s 🟩
permission-check 2s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 4m +67%
cli-e2e-tests / run-cli-tests 9m 7m +36%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma changed the base branch from main to zjma/dkg_manager_update_from_randomnet February 25, 2024 20:49
@zjma zjma marked this pull request as ready for review February 25, 2024 20:49
@zjma zjma requested review from zekun000 and removed request for gregnazario, lightmark, msmouse, grao1991, banool and 0xmaayan February 25, 2024 20:49
@zjma zjma assigned danielxiangzl and unassigned danielxiangzl Feb 25, 2024
@zjma zjma force-pushed the zjma/dkg_manager_update_from_randomnet branch from a205b1e to e675e73 Compare February 28, 2024 14:38
@zjma zjma force-pushed the zjma/try_as_block_metadata_fix_from_randomnet branch from d75d24d to 9ae741d Compare February 28, 2024 14:46
@zjma zjma force-pushed the zjma/try_as_block_metadata_fix_from_randomnet branch from 9ae741d to bd1cc34 Compare February 28, 2024 14:48
Base automatically changed from zjma/dkg_manager_update_from_randomnet to main February 29, 2024 02:34
@zjma zjma force-pushed the zjma/try_as_block_metadata_fix_from_randomnet branch from bd1cc34 to 7e32ff9 Compare February 29, 2024 02:39
@zjma zjma enabled auto-merge (squash) February 29, 2024 02:43

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 7e32ff9b9ee3cf8d99cf57a3642736cf3b61dcc0

Compatibility test results for aptos-node-v1.9.5 ==> 7e32ff9b9ee3cf8d99cf57a3642736cf3b61dcc0 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6972 txn/s, latency: 4755 ms, (p50: 4800 ms, p90: 7400 ms, p99: 9000 ms), latency samples: 244020
2. Upgrading first Validator to new version: 7e32ff9b9ee3cf8d99cf57a3642736cf3b61dcc0
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1760 txn/s, latency: 16892 ms, (p50: 18300 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 89760
3. Upgrading rest of first batch to new version: 7e32ff9b9ee3cf8d99cf57a3642736cf3b61dcc0
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 296 txn/s, submitted: 564 txn/s, expired: 268 txn/s, latency: 30082 ms, (p50: 24900 ms, p90: 58000 ms, p99: 72600 ms), latency samples: 28159
4. upgrading second batch to new version: 7e32ff9b9ee3cf8d99cf57a3642736cf3b61dcc0
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2388 txn/s, latency: 12675 ms, (p50: 14400 ms, p90: 15600 ms, p99: 16300 ms), latency samples: 105100
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 7e32ff9b9ee3cf8d99cf57a3642736cf3b61dcc0 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7e32ff9b9ee3cf8d99cf57a3642736cf3b61dcc0

two traffics test: inner traffic : committed: 7378 txn/s, latency: 5295 ms, (p50: 5100 ms, p90: 6300 ms, p99: 10800 ms), latency samples: 3202180
two traffics test : committed: 100 txn/s, latency: 1842 ms, (p50: 1800 ms, p90: 2100 ms, p99: 2700 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.230, avg: 0.202", "QsPosToProposal: max: 0.305, avg: 0.289", "ConsensusProposalToOrdered: max: 0.456, avg: 0.442", "ConsensusOrderedToCommit: max: 0.318, avg: 0.304", "ConsensusProposalToCommit: max: 0.764, avg: 0.745"]
Max round gap was 1 [limit 4] at version 1539496. Max no progress secs was 4.042545 [limit 15] at version 1539496.
Test Ok

@zjma zjma merged commit 39a9360 into main Feb 29, 2024
79 of 82 checks passed
@zjma zjma deleted the zjma/try_as_block_metadata_fix_from_randomnet branch February 29, 2024 03:32
zjma added a commit that referenced this pull request Mar 3, 2024
* randomness type update 3 (#12202)

* randomness #4: RandManager update from randomnet (#12224)

* RandManager update from randomnet

* lint

* lint

* randomness #5: consensus update from randomnet (#12225)

* consensus update from randomnet

* update

* randomness #6: dkg manager update from randomnet (#12226)

* consensus update from randomnet

* update

* update execution client api

* dkg manager update from randomnet

* avoid panic

* make api, indexer, fake aptos db aware of block metadata ext txns (#12227)

* randomness #8: framework update from randomnet (#12228)

* framework update from randomnet

Squashed commit of the following to fix jwk smoke tests:

commit 3bd0154
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 02:47:57 2024 -0800

    update

commit 2eb6add
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 02:12:27 2024 -0800

    update

commit 9d82151
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 01:51:08 2024 -0800

    debug

fix doc test

fix spec

fix doc

update initialization in genesis

update features.move

initialize randomness in genesis

update golden files

private entry fun check and vm updates

* postpone release builder changes

* update goldenfiles

* fix is_safe_call spec

* randomness #9: smoke tests from randomnet (#12282)

* smoke test deps and 1st case from randomnet

* update

* more smoke tests

* randomness #10: randomness API update from randomnet (#12335)

* [move] fixes to `randomness.move` (#12250)

* [move] fixes to randomness.move

* Fixed the Prover spec

Fixed the spec to unblock the PR.

Need to prove the introduced assumptions with proper loop invariants, which should be provable.

* lint

---------

Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>

* fix specs

---------

Co-authored-by: Alin Tomescu <[email protected]>
Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>

* lint

* update genesis

* on-chain resources to indicate dkg/randomness failure injection (#12345)

* dkg/randomness failure injection

* update

* smoke test

* update

* update

* fix scripts

---------

Co-authored-by: Alin Tomescu <[email protected]>
Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants