Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types update from randomnet 3 #12202

Merged
merged 2 commits into from
Feb 23, 2024
Merged

types update from randomnet 3 #12202

merged 2 commits into from
Feb 23, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Feb 23, 2024

Description

Test Plan

Copy link

trunk-io bot commented Feb 23, 2024

⏱️ 16h 15m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 4h 24m 🟩
rust-smoke-coverage 3h 5m 🟩
rust-unit-tests 2h 53m 🟩
windows-build 1h 20m 🟩🟩🟩🟩
rust-smoke-tests 1h 4m 🟩🟩
execution-performance / single-node-performance 39m 🟩🟥🟩
forge-compat-test / forge 32m 🟩🟩
forge-e2e-test / forge 27m 🟩🟩
rust-images / rust-all 27m 🟩🟩
cli-e2e-tests / run-cli-tests 19m 🟩🟩
rust-lints 19m 🟩🟩
run-tests-main-branch 13m 🟥🟥
check 8m 🟩🟩
check-dynamic-deps 8m 🟩🟩🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 5m 🟩🟩
general-lints 4m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 1m 🟩🟩🟩🟩
upload-to-codecov 43s 🟥
file_change_determinator 31s 🟩🟩
execution-performance / file_change_determinator 26s 🟩🟩🟩
file_change_determinator 25s 🟩🟩
file_change_determinator 20s 🟩🟩
permission-check 13s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 10s 🟩🟩🟩🟩
determine-docker-build-metadata 2s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 14m 6m +119%
run-tests-main-branch 6m 4m +62%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Feb 23, 2024
@zjma zjma changed the title randomness type update 3 types update from randomnet 3 Feb 23, 2024
@zjma zjma marked this pull request as ready for review February 23, 2024 20:05

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

}
}

pub fn enable_validator_txns(&mut self) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is a mutation? how do we use this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later in smoke tests, example here

@zjma zjma enabled auto-merge (squash) February 23, 2024 22:27

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c28a327a3c31e678470b57a248520f0ba883c0e7

two traffics test: inner traffic : committed: 7178 txn/s, latency: 5448 ms, (p50: 5100 ms, p90: 7400 ms, p99: 11400 ms), latency samples: 3115680
two traffics test : committed: 100 txn/s, latency: 2007 ms, (p50: 2000 ms, p90: 2300 ms, p99: 3800 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.230, avg: 0.201", "QsPosToProposal: max: 0.260, avg: 0.234", "ConsensusProposalToOrdered: max: 0.573, avg: 0.544", "ConsensusOrderedToCommit: max: 0.381, avg: 0.358", "ConsensusProposalToCommit: max: 0.921, avg: 0.902"]
Max round gap was 1 [limit 4] at version 1468232. Max no progress secs was 3.994182 [limit 15] at version 1468232.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> c28a327a3c31e678470b57a248520f0ba883c0e7

Compatibility test results for aptos-node-v1.9.5 ==> c28a327a3c31e678470b57a248520f0ba883c0e7 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 5265 txn/s, latency: 5425 ms, (p50: 5000 ms, p90: 7500 ms, p99: 10100 ms), latency samples: 210600
2. Upgrading first Validator to new version: c28a327a3c31e678470b57a248520f0ba883c0e7
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 846 txn/s, latency: 32319 ms, (p50: 37100 ms, p90: 50200 ms, p99: 50500 ms), latency samples: 56740
3. Upgrading rest of first batch to new version: c28a327a3c31e678470b57a248520f0ba883c0e7
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 299 txn/s, submitted: 488 txn/s, expired: 189 txn/s, latency: 30246 ms, (p50: 24200 ms, p90: 54300 ms, p99: 71900 ms), latency samples: 31167
4. upgrading second batch to new version: c28a327a3c31e678470b57a248520f0ba883c0e7
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2304 txn/s, latency: 13005 ms, (p50: 14100 ms, p90: 15100 ms, p99: 15600 ms), latency samples: 103680
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> c28a327a3c31e678470b57a248520f0ba883c0e7 passed
Test Ok

@zjma zjma merged commit 691bbbd into main Feb 23, 2024
55 of 71 checks passed
@zjma zjma deleted the zjma/type-update-3 branch February 23, 2024 22:59
zjma added a commit that referenced this pull request Mar 1, 2024
zjma added a commit that referenced this pull request Mar 2, 2024
zjma added a commit that referenced this pull request Mar 3, 2024
* randomness type update 3 (#12202)

* randomness #4: RandManager update from randomnet (#12224)

* RandManager update from randomnet

* lint

* lint

* randomness #5: consensus update from randomnet (#12225)

* consensus update from randomnet

* update

* randomness #6: dkg manager update from randomnet (#12226)

* consensus update from randomnet

* update

* update execution client api

* dkg manager update from randomnet

* avoid panic

* make api, indexer, fake aptos db aware of block metadata ext txns (#12227)

* randomness #8: framework update from randomnet (#12228)

* framework update from randomnet

Squashed commit of the following to fix jwk smoke tests:

commit 3bd0154
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 02:47:57 2024 -0800

    update

commit 2eb6add
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 02:12:27 2024 -0800

    update

commit 9d82151
Author: zhoujun.ma <[email protected]>
Date:   Tue Feb 27 01:51:08 2024 -0800

    debug

fix doc test

fix spec

fix doc

update initialization in genesis

update features.move

initialize randomness in genesis

update golden files

private entry fun check and vm updates

* postpone release builder changes

* update goldenfiles

* fix is_safe_call spec

* randomness #9: smoke tests from randomnet (#12282)

* smoke test deps and 1st case from randomnet

* update

* more smoke tests

* randomness #10: randomness API update from randomnet (#12335)

* [move] fixes to `randomness.move` (#12250)

* [move] fixes to randomness.move

* Fixed the Prover spec

Fixed the spec to unblock the PR.

Need to prove the introduced assumptions with proper loop invariants, which should be provable.

* lint

---------

Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>

* fix specs

---------

Co-authored-by: Alin Tomescu <[email protected]>
Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>

* lint

* update genesis

* on-chain resources to indicate dkg/randomness failure injection (#12345)

* dkg/randomness failure injection

* update

* smoke test

* update

* update

* fix scripts

---------

Co-authored-by: Alin Tomescu <[email protected]>
Co-authored-by: Junkil Park <[email protected]>
Co-authored-by: danielxiangzl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants