randomness #6: dkg manager update from randomnet #12226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjma
added
the
CICD:run-e2e-tests
zjma
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| }, | ||
| close_req = close_rx.select_next_some() => { | ||
| self.process_close_cmd(close_req.ok()) | ||
| } | ||
| }, | ||
| _ = interval.tick().fuse() => { |
There was a problem hiding this comment.
Not sure if this is the best practice for logging.. @zekun000 thoughts?
There was a problem hiding this comment.
it's okay but this will print out the whole transcript bytes?
There was a problem hiding this comment.
ah i see there's a Debug impl for the transcript
dkg/src/dkg_manager/mod.rs
Outdated
| ); | ||
| self.setup_deal_broadcast(start_time_us, &metadata) | ||
| .await | ||
| .expect("[DKG] setup_deal_broadcast() should be infallible"); |
There was a problem hiding this comment.
Maybe alert instead of expect?
There was a problem hiding this comment.
the only error is if inner state is not NotStarted?
| @@ -27,15 +29,26 @@ impl<S: DKGTrait> Default for TranscriptAggregator<S> { | |||
| } | |||
|
|
|||
| pub struct TranscriptAggregationState<DKG: DKGTrait> { | |||
| start_time: Duration, | |||
| my_addr: AccountAddress, | |||
| valid_peer_transcript_seen: bool, | |||
There was a problem hiding this comment.
It is never set to be true?
zjma
force-pushed
the
zjma/consensus_update_from_randomnet
branch
from
911292f to
0db1642
Compare
zjma
requested review from
sasha8,
ibalajiarun,
JoshLind and
gregnazario
as code owners
zjma
force-pushed
the
zjma/consensus_update_from_randomnet
branch
from
166f1b6 to
2392d2a
Compare
zjma
force-pushed
the
zjma/dkg_manager_update_from_randomnet
branch
from
a205b1e to
e675e73
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Base automatically changed from
zjma/consensus_update_from_randomnet
to
main
February 28, 2024 22:34
zekun000
approved these changes
Feb 28, 2024
dkg/src/dkg_manager/mod.rs
Outdated
| ); | ||
| self.setup_deal_broadcast(start_time_us, &metadata) | ||
| .await | ||
| .expect("[DKG] setup_deal_broadcast() should be infallible"); |
There was a problem hiding this comment.
the only error is if inner state is not NotStarted?
| }, | ||
| close_req = close_rx.select_next_some() => { | ||
| self.process_close_cmd(close_req.ok()) | ||
| } | ||
| }, | ||
| _ = interval.tick().fuse() => { |
There was a problem hiding this comment.
it's okay but this will print out the whole transcript bytes?
| }, | ||
| close_req = close_rx.select_next_some() => { | ||
| self.process_close_cmd(close_req.ok()) | ||
| } | ||
| }, | ||
| _ = interval.tick().fuse() => { |
There was a problem hiding this comment.
ah i see there's a Debug impl for the transcript
| "[DKG] txn executed and entering new epoch.", | ||
| ); | ||
|
|
||
| drop(vtxn_guard); |
There was a problem hiding this comment.
no need for explicit drop?
danielxiangzl
approved these changes
Feb 28, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
zjma
added a commit
that referenced
this pull request
Mar 1, 2024
* consensus update from randomnet * update * update execution client api * dkg manager update from randomnet * avoid panic
zjma
added a commit
that referenced
this pull request
Mar 2, 2024
* consensus update from randomnet * update * update execution client api * dkg manager update from randomnet * avoid panic
zjma
added a commit
that referenced
this pull request
Mar 3, 2024
* randomness type update 3 (#12202) * randomness #4: RandManager update from randomnet (#12224) * RandManager update from randomnet * lint * lint * randomness #5: consensus update from randomnet (#12225) * consensus update from randomnet * update * randomness #6: dkg manager update from randomnet (#12226) * consensus update from randomnet * update * update execution client api * dkg manager update from randomnet * avoid panic * make api, indexer, fake aptos db aware of block metadata ext txns (#12227) * randomness #8: framework update from randomnet (#12228) * framework update from randomnet Squashed commit of the following to fix jwk smoke tests: commit 3bd0154 Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 02:47:57 2024 -0800 update commit 2eb6add Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 02:12:27 2024 -0800 update commit 9d82151 Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 01:51:08 2024 -0800 debug fix doc test fix spec fix doc update initialization in genesis update features.move initialize randomness in genesis update golden files private entry fun check and vm updates * postpone release builder changes * update goldenfiles * fix is_safe_call spec * randomness #9: smoke tests from randomnet (#12282) * smoke test deps and 1st case from randomnet * update * more smoke tests * randomness #10: randomness API update from randomnet (#12335) * [move] fixes to `randomness.move` (#12250) * [move] fixes to randomness.move * Fixed the Prover spec Fixed the spec to unblock the PR. Need to prove the introduced assumptions with proper loop invariants, which should be provable. * lint --------- Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * fix specs --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * lint * update genesis * on-chain resources to indicate dkg/randomness failure injection (#12345) * dkg/randomness failure injection * update * smoke test * update * update * fix scripts --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan