-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
randomness #4: RandManager update from randomnet #12224
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12224 +/- ##
========================================
Coverage 70.0% 70.0%
========================================
Files 2240 2240
Lines 422197 422544 +347
========================================
+ Hits 295551 295878 +327
- Misses 126646 126666 +20 ☔ View full report in Codecov by Sentry. |
pub fn observe_queue(&self) { | ||
let queue = &self.block_queue.queue; | ||
RAND_QUEUE_SIZE.set(queue.len() as i64); | ||
info!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgrade to debug? Or maybe we only print if the queue is too large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed.
@@ -85,9 +86,20 @@ impl QueueItem { | |||
|
|||
/// Maintain ordered blocks that have pending randomness | |||
pub struct BlockQueue { | |||
queue: BTreeMap<Round, QueueItem>, | |||
pub queue: BTreeMap<Round, QueueItem>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this pub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
let _guard = self.broadcast_certified_aug_data(certified_data); | ||
|
||
let _guard = self.broadcast_aug_data().await; | ||
let mut interval = tokio::time::interval(Duration::from_millis(5000)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: just use from_secs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
* RandManager update from randomnet * lint * lint
* RandManager update from randomnet * lint * lint
* randomness type update 3 (#12202) * randomness #4: RandManager update from randomnet (#12224) * RandManager update from randomnet * lint * lint * randomness #5: consensus update from randomnet (#12225) * consensus update from randomnet * update * randomness #6: dkg manager update from randomnet (#12226) * consensus update from randomnet * update * update execution client api * dkg manager update from randomnet * avoid panic * make api, indexer, fake aptos db aware of block metadata ext txns (#12227) * randomness #8: framework update from randomnet (#12228) * framework update from randomnet Squashed commit of the following to fix jwk smoke tests: commit 3bd0154 Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 02:47:57 2024 -0800 update commit 2eb6add Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 02:12:27 2024 -0800 update commit 9d82151 Author: zhoujun.ma <[email protected]> Date: Tue Feb 27 01:51:08 2024 -0800 debug fix doc test fix spec fix doc update initialization in genesis update features.move initialize randomness in genesis update golden files private entry fun check and vm updates * postpone release builder changes * update goldenfiles * fix is_safe_call spec * randomness #9: smoke tests from randomnet (#12282) * smoke test deps and 1st case from randomnet * update * more smoke tests * randomness #10: randomness API update from randomnet (#12335) * [move] fixes to `randomness.move` (#12250) * [move] fixes to randomness.move * Fixed the Prover spec Fixed the spec to unblock the PR. Need to prove the introduced assumptions with proper loop invariants, which should be provable. * lint --------- Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * fix specs --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]> * lint * update genesis * on-chain resources to indicate dkg/randomness failure injection (#12345) * dkg/randomness failure injection * update * smoke test * update * update * fix scripts --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Junkil Park <[email protected]> Co-authored-by: danielxiangzl <[email protected]>
Description
Test Plan