-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(composition): Relax @tag definition validation #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I have all the context, but implementing an immediate workaround for the lack of repeatable
support in Kotlin definitely makes sense to me. I also think we want to be more lenient in allowing differences between directive definitions in general. I'd prefer if we came up with a design for that first though, and think through the consequences to make sure this is something we feel comfortable supporting for all directives.
Leaving out repeatable
has no effect on the semantics of directive applications (except that there would never be more than one tag per element for that subgraph).
Additional arguments are a somewhat different case however, because we have no way of knowing what a user's intention is. So just ignoring them might be surprising or even dangerous. We may also want to differentiate between nullable and non-nullable arguments, or take default values into account.
85e0c24
to
2c4105b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fixes #1021