Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @tag definitions #328

Closed
wants to merge 1 commit into from
Closed

Conversation

trevor-scheer
Copy link
Member

No description provided.

Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @prasek these are the changes to make composition succeed

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Sep 21, 2021

lets hold off merging this until we are ready to release rover (likely tomorrow), then we can have a smaller window where CI is failing due to old builds of rover

edit:

confirmation that this does work with the avery/update-harmonizer branch on the rover repo:

$ cargo xtask integration-test --branch trevor/update-tag-defs
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/xtask integration-test --branch trevor/update-tag-defs`
info: running `cargo build --target x86_64-unknown-linux-gnu` in `/home/avery/work/rover`
info: successfully compiled to `/home/avery/work/rover/target/x86_64-unknown-linux-gnu/debug/rover`
info: running `git clone https://github.com/apollographql/supergraph-demo --branch trevor/update-tag-defs` in `/tmp/.tmpbdZhRE`
info: running `make ci` in `/tmp/.tmpbdZhRE/supergraph-demo`
info: successfully ran supergraph-demo with a local binary.
Success!

@prasek
Copy link
Contributor

prasek commented Sep 21, 2021

@trevor-scheer if apollographql/federation#1022 will allow the existing @tag directive declarations to work then perhaps we can cut a new harmonizer with that and use that for the new rover drop? /cc @EverlastingBugstopper @abernix

@EverlastingBugstopper
Copy link
Contributor

This PR can be closed

@prasek prasek closed this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants