-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates harmonizer to v0.30.0 #832
Conversation
02c417e
to
f941125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! (reviewed docs content only)
Thanks @abernix - I like what you wrote quite a bit more than what I wrote! |
64fe4e7
to
3ac8f96
Compare
@abernix I've added a section to the docs calling out additional requirements for the @trevor-scheer was helpful here and noted that this is just a temporary breaking change and future versions will not have these additional requirements |
Unbreak will happen via this PR: apollographql/federation#1022 |
confirmation that this works with the $ cargo xtask integration-test --branch trevor/update-tag-defs
Finished dev [unoptimized + debuginfo] target(s) in 0.08s
Running `target/debug/xtask integration-test --branch trevor/update-tag-defs`
info: running `cargo build --target x86_64-unknown-linux-gnu` in `/home/avery/work/rover`
info: successfully compiled to `/home/avery/work/rover/target/x86_64-unknown-linux-gnu/debug/rover`
info: running `git clone https://github.com/apollographql/supergraph-demo --branch trevor/update-tag-defs` in `/tmp/.tmpbdZhRE`
info: running `make ci` in `/tmp/.tmpbdZhRE/supergraph-demo`
info: successfully ran supergraph-demo with a local binary.
Success! |
Labelled this as blocked until we resolve the |
e75ec8b
to
8324d4c
Compare
b53b452
to
b3f901f
Compare
fixes #801 by updating harmonizer to v0.30.0, which is a breaking change for folks using
rover supergraph compose
with versions of@apollo/gateway
< v0.39.0. This is reflected in the docs and will also be called out in our changelog.cc @StephenBarlow for docs wording/structure review
cc @trevor-scheer for content review
cc @abernix for rubber stamp
cc @prasek because
supergraph-demo
fails to compose with this version bump.