Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(composition): Relax @tag directive definition validation #1021

Closed
trevor-scheer opened this issue Sep 21, 2021 · 0 comments · Fixed by #1022
Closed

feat(composition): Relax @tag directive definition validation #1021

trevor-scheer opened this issue Sep 21, 2021 · 0 comments · Fixed by #1022
Assignees

Comments

@trevor-scheer
Copy link
Member

Users should be allowed to provide a @tag directive definition which is a "subset" of the spec'ed @tag directive. i.e. the validation should permit leaving out repeatable or any of the directive locations. But it should continue to enforce the non-null arg name: String!.

This is in response to a lack of repeatable support in Kotlin, but also seems like a reasonable pattern to follow for core directives going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant