Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] <Move code from controller to service in module hertzbeat-manager> #2407

Closed
5 of 6 tasks
Calvin979 opened this issue Jul 29, 2024 · 6 comments · Fixed by #2433
Closed
5 of 6 tasks

[Task] <Move code from controller to service in module hertzbeat-manager> #2407

Calvin979 opened this issue Jul 29, 2024 · 6 comments · Fixed by #2433
Assignees
@pwallk @ceekay47
Labels
good first issue Good for newcomers refactor status: volunteer wanted task

Comments

@Calvin979
Copy link
Contributor

Calvin979 commented Jul 29, 2024 •
edited
Loading

Description

Move code from controller to service in module hertzbeat-manager.
See also: #2373
As a layer of interaction with front-end, controller should not contain any code logic except param validation.

Comment down below if you want to claim task.
eg: I claim xxxController

Task List

  • org.apache.hertzbeat.manager.controller.CollectorController
  • org.apache.hertzbeat.manager.controller.GeneralConfigController
  • org.apache.hertzbeat.manager.controller.MonitorsController
  • org.apache.hertzbeat.manager.controller.NoticeConfigController
  • org.apache.hertzbeat.manager.controller.PluginController
  • org.apache.hertzbeat.manager.controller.TagController
@Calvin979 Calvin979 assigned Calvin979 and unassigned Calvin979 Jul 29, 2024
@ceekay47
Copy link
Contributor

Hi @Calvin979, I would like to contribute. I can look into refactoring CollectorController to get started. Can you please provide some context?

@pwallk
Copy link
Contributor

pwallk commented Jul 30, 2024

I can finish the rest of the controller

@Calvin979
Copy link
Contributor Author

Hi @Calvin979, I would like to contribute. I can look into refactoring CollectorController to get started. Can you please provide some context?

Welcome! Maybe you can refer this pr: #2373
The key is that the responsibility of Controller is to validate param only.
There are some controllers contain a lot of codes out of its responsiblity and that's why we wanna refactor them.

@Calvin979
Copy link
Contributor Author

I can finish the rest of the controller

Welcome! Suggest one pr for one controller only.

This was referenced Jul 30, 2024
Merged
Merged
Merged
Merged
Merged
@Calvin979 Calvin979 changed the title [Task] <Move code from controller to service> [Task] <Move code from controller to service in module hertzbeat-manager> Jul 31, 2024
@Calvin979 Calvin979 mentioned this issue Jul 31, 2024
Closed
6 tasks
@Calvin979 Calvin979 linked a pull request Aug 1, 2024 that will close this issue
[refactor] move code from CollectorController to CollectorService #2433
Merged
4 tasks
@MRgenial
Copy link
Contributor

MRgenial commented Aug 8, 2024

I claim collectorController

@Calvin979
Copy link
Contributor Author

Calvin979 commented Aug 8, 2024 •
edited
Loading

I claim collectorController

Thanks for your enthusiasm. CollectorController has been assigned to @ceekay47. You can try to find another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwallk pwallk

@ceekay47 ceekay47

Labels
good first issue Good for newcomers refactor status: volunteer wanted task
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] move code from CollectorController to CollectorService ceekay47/hertzbeat
4 participants
@MRgenial @pwallk @ceekay47 @Calvin979