Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] <Move code from controller to service> #2427

Closed
5 of 6 tasks
Calvin979 opened this issue Jul 31, 2024 · 1 comment · Fixed by #2437
Closed
5 of 6 tasks

[Task] <Move code from controller to service> #2427

Calvin979 opened this issue Jul 31, 2024 · 1 comment · Fixed by #2437
Assignees
@pwallk
Labels
good first issue Good for newcomers refactor status: volunteer wanted task

Comments

@Calvin979
Copy link
Contributor

Calvin979 commented Jul 31, 2024 •
edited
Loading

Description

Move code from controller to service in module hertzbeat-alerter and hertzbeat-warehouse.
See also: #2373 #2407
As a layer of interaction with front-end, controller should not contain any code logic except param validation.

Comment down below if you want to claim task.
eg: I claim xxxController

Task List

  • org.apache.hertzbeat.alert.controller.AlertConvergesController
  • org.apache.hertzbeat.alert.controller.AlertDefinesController
  • org.apache.hertzbeat.alert.controller.AlertReportController
  • org.apache.hertzbeat.alert.controller.AlertsController
  • org.apache.hertzbeat.alert.controller.AlertSilencesController
  • org.apache.hertzbeat.warehouse.controller.MetricsDataController
@pwallk
Copy link
Contributor

pwallk commented Aug 1, 2024

I already have experience with this Task and I can complete these

This was referenced Aug 1, 2024
Merged
Merged
Merged
Merged
Merged
@pwallk pwallk mentioned this issue Aug 1, 2024
Merged
5 tasks
@Calvin979 Calvin979 linked a pull request Aug 5, 2024 that will close this issue
[refactor] move code from MetricsDataController to MetricsService #2437
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwallk pwallk

Labels
good first issue Good for newcomers refactor status: volunteer wanted task
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] move code from MetricsDataController to MetricsService pwallk/hertzbeat
2 participants
@pwallk @Calvin979