[refactor] move code from AccountController to AccountService #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
reviewed
Jul 26, 2024
Comment on lines
25
to
32
| /** | ||
| * Account service | ||
| */ | ||
| public interface AccountService { | ||
| Map<String, String> authGetToken(LoginDto loginDto) throws AuthenticationException; | ||
|
|
||
| RefreshTokenResponse refreshToken(String refreshToken) throws AuthenticationException; | ||
| } |
There was a problem hiding this comment.
hi can you help add code comments in interface method
There was a problem hiding this comment.
Code comments has added
|
@tomsun28 There are some controllers have the same problem like this pr. |
hi, ok. 👍 |
tomsun28
approved these changes
Jul 28, 2024
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
As a layer of interaction with front-end, controller should not contain any code logic.
Checklist
Add or update API