-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] move code from AlertsController to AlertService #2435
Conversation
# Conflicts: # alerter/src/main/java/org/apache/hertzbeat/alert/service/impl/AlertDefineServiceImpl.java
&& argument.getPageSize() == pageRequest.getPageSize() | ||
&& argument.getSort().equals(pageRequest.getSort()) | ||
) | ||
ids, 1L, (byte) 1, (byte) 1, "test", sortField, orderType, pageIndex, pageSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Could you help fix this test. Unit tests are passed because this test method is not annotated with @Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
@@ -18,7 +18,7 @@ spring: | |||
application: | |||
name: ${HOSTNAME:@hertzbeat@}${PID} | |||
profiles: | |||
active: prod | |||
active: pg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why modify application.yml
? Looks like it is a dev configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot to rollback
# Conflicts: # alerter/src/main/java/org/apache/hertzbeat/alert/service/impl/AlertServiceImpl.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's changed?
Checklist
Add or update API