Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] move code from NoticeConfigController to NoticeConfigService #2416

Merged
merged 4 commits into from
Jul 30, 2024
Merged

[refactor] move code from NoticeConfigController to NoticeConfigService #2416

merged 4 commits into from
Jul 30, 2024

Conversation

pwallk
Copy link
Contributor

@pwallk pwallk commented Jul 30, 2024

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Calvin979 Calvin979 merged commit c7f4390 into apache:master Jul 30, 2024
3 checks passed
@pwallk pwallk deleted the reactor-NoticeConfigController branch August 1, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calvin979 Calvin979 Calvin979 approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwallk @Calvin979