[refactor] move code from CollectorController to CollectorService #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
it seems that code style question: you can run |
|
@ceekay47 Hi, please fix Backend CI on your branch when you have time. |
added 2 commits
August 8, 2024 00:31
|
@Calvin979 @yuluo-yx Fixed the Checkstyle errors. Can you please take a look? Thanks. |
Calvin979
reviewed
Aug 8, 2024
| try { | ||
| this.collectorService.deleteRegisteredCollector(collectors); | ||
| return ResponseEntity.ok(Message.success("Delete success")); | ||
| } catch (CommonException ex) { |
There was a problem hiding this comment.
This can be removed because CommonException is handled by GlobalExceptionHandler.
| return ResponseEntity.ok(Message.fail(CommonConstants.FAIL_CODE, "There already has same collector name.")); | ||
| try { | ||
| return ResponseEntity.ok(Message.success(collectorService.generateCollectorDeployInfo(collector))); | ||
| } catch (CommonException ex) { |
Calvin979
approved these changes
Aug 9, 2024
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Move code from CollectorController to CollectorService
Checklist
Add or update API