[#3914] feat(server): Add REST server interface for Tag System #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (apache#4123) ### What changes were proposed in this pull request? Add fileset commet removal operations: FilesetChange.RemoveComment Fix: apache#4112 ### Why are the changes needed? Fileset can be created without comment now, when user added a comment to fileset, they should be allowed to retract the comment. Like other FilesetChange, FilesetChange.RemoveComment can be used for **alterFileset()** method ### Does this PR introduce _any_ user-facing change? User can add new changes for fileset: ``` Fileset fileset = catalog.asFilesetCatalog().alterFileset( NameIdentifier.of(metaLakeName, catalogName, schemaName, filesetName), FilesetChange.removeComment()); ``` or use update fileset http request: ``` updates": [ { "@type": "removeComment" } ] ``` ### How was this patch tested? Create a fileset with comment, then use java/python client, or http requeset to remove comment and check the result
…-connector (apache#4144) ### Why are the changes needed? Fix: apache#4135 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UTs
…pache#4121) ### What changes were proposed in this pull request? Remove the logic of getValidRoles. ### Why are the changes needed? Fix: apache#4105 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Modify some test cases.
### What changes were proposed in this pull request? Fixed an unreachable link. ### Why are the changes needed? Fix: apache#4155 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No testing required Co-authored-by: rqyin <[email protected]>
yuqi1129
reviewed
Jul 18, 2024
clients/client-java/src/main/java/org/apache/gravitino/client/ObjectMapperProvider.java
Show resolved
Hide resolved
common/src/main/java/org/apache/gravitino/dto/responses/MetadataObjectListResponse.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/gravitino/server/web/rest/TagOperations.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/gravitino/server/web/rest/TagOperations.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/gravitino/server/web/rest/TagOperations.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Jul 18, 2024
server/src/main/java/org/apache/gravitino/server/web/rest/TagOperations.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Jul 19, 2024
| @@ -16,7 +16,6 @@ | |||
| * specific language governing permissions and limitations | |||
| * under the License. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
Is this empty line expected?
There was a problem hiding this comment.
No, there's no rule that here should have an empty line.
server/src/main/java/org/apache/gravitino/server/web/rest/ExceptionHandlers.java
Show resolved
Hide resolved
|
@jerqi |
|
@jerqi can you please help me to review it? |
jerqi
reviewed
Jul 22, 2024
common/src/main/java/org/apache/gravitino/dto/responses/MetadataObjectListResponse.java
Outdated
Show resolved
Hide resolved
| * @param fullName The full name of the metadata object. | ||
| */ | ||
| @JsonProperty("fullName") | ||
| public void setFullName(String fullName) { |
There was a problem hiding this comment.
Why do we need this method instead of using builder? MetadataObjectDTO became a mutable object?
There was a problem hiding this comment.
It is only for Jackson to use.
|
Why do you choose to use lock inside the TagManager instead of TagOperations? |
I personally don't like wrapping everything into the lock in the operations, which is hard to do fine-grained control. Besides, previously I didn't even want to use lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add REST server interface for Tag System
Why are the changes needed?
This is a part of work for Tag system.
Fix: #3914
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
UTs added.