[#4105] improvement(core): Remove the logic of getValidRoles #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerryshao @yuqi1129 Could you help me review this pull request? |
jerqi
force-pushed
the
ISSUE-4105
branch
2 times, most recently
from
d934a3c to
be9cea6
Compare
jerryshao
reviewed
Jul 10, 2024
| for (String role : userEntity.roleNames()) { | ||
| roleEntities.add(roleManager.getRole(metalake, role)); | ||
| } | ||
| } |
There was a problem hiding this comment.
I would suggest that we don't store the role name in user entity, only store the id, and we don't need to check role name, but the role id.
There was a problem hiding this comment.
We don't store role name in the underlying relational database. It's necessary for us to assign the role names fields in the user entity. The updated user entity will be returned to end user. The users of requests need role names for human understanding.
jerryshao
approved these changes
Jul 12, 2024
jerryshao
changed the title
jerryshao
pushed a commit
to jerryshao/gravitino
that referenced
this pull request
Jul 16, 2024
…pache#4121) ### What changes were proposed in this pull request? Remove the logic of getValidRoles. ### Why are the changes needed? Fix: apache#4105 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Modify some test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the logic of getValidRoles.
Why are the changes needed?
Fix: #4105
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modify some test cases.