Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove the logic of getValidRoles #4105

Closed
jerqi opened this issue Jul 9, 2024 · 0 comments · Fixed by #4121
Closed

[Improvement] Remove the logic of getValidRoles #4105

jerqi opened this issue Jul 9, 2024 · 0 comments · Fixed by #4121
Assignees
@jerqi
Labels
0.6.0 Release v0.6.0 improvement Improvements on everything

Comments

@jerqi
Copy link
Contributor

jerqi commented Jul 9, 2024

What would you like to be improved?

Because we ever wanted to adapt to the kv storage, we added the logic of getValidRoles. Now kv storage is deprecated. So we can remove the logic of getValidRoles.

How should we improve?

we can remove the logic of getValidRoles.
@jerqi jerqi added the improvement Improvements on everything label Jul 9, 2024
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 10, 2024
@jerqi
[apache#4105] improvement: Remove the logic of getValidRoles
2ced776
@jerqi jerqi mentioned this issue Jul 10, 2024
Merged
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 10, 2024
@jerqi
[apache#4105] improvement: Remove the logic of getValidRoles
3d9229d
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 10, 2024
@jerqi
[apache#4105] improvement: Remove the logic of getValidRoles
d934a3c
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 10, 2024
@jerqi
[apache#4105] improvement: Remove the logic of getValidRoles
be9cea6
jerqi added a commit to qqqttt123/gravitino that referenced this issue Jul 10, 2024
@jerqi
[apache#4105] improvement: Remove the logic of getValidRoles
eb73cad
@jerryshao jerryshao added the 0.6.0 Release v0.6.0 label Jul 12, 2024
jerryshao pushed a commit to jerryshao/gravitino that referenced this issue Jul 16, 2024
@jerqi @jerryshao
[apache#4105] improvement(core): Remove the logic of getValidRoles (a…
bd604fc 
…pache#4121)

### What changes were proposed in this pull request?

Remove the logic of getValidRoles.

### Why are the changes needed?

Fix: apache#4105 

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Modify some test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerqi jerqi

Labels
0.6.0 Release v0.6.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4105] improvement(core): Remove the logic of getValidRoles qqqttt123/gravitino
2 participants
@jerryshao @jerqi