[#2081] feat(core): Add JDBC backend operations for catalog #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
from
47b817a to
dd43519
Compare
10 tasks
xloya
changed the title
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
from
dd43519 to
5045da9
Compare
YxAc
reviewed
Feb 17, 2024
xloya
changed the title
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
4 times, most recently
from
27f45e3 to
9c5eaa8
Compare
|
We use Spotless to ensure code is consistently formatted, look likes there is a formatting error that you can fix with |
Since the dependent PR is still under review, the PR has not been updated in time. This PR will be updated today. Thanks. |
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
3 times, most recently
from
972dcf8 to
82c4e8c
Compare
added 15 commits
February 26, 2024 10:07
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
3 times, most recently
from
f08e9f6 to
e789c5a
Compare
|
@xloya |
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
from
e789c5a to
3309d12
Compare
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
from
3309d12 to
db62749
Compare
|
Also gentle pin @jerryshao @qqqttt123 @coolderli for reviews. |
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
from
db62749 to
fada86d
Compare
yuqi1129
reviewed
Feb 27, 2024
api/src/main/java/com/datastrato/gravitino/exceptions/NoSuchEntityException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CatalogMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CatalogMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CatalogMetaService.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CatalogMetaService.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CatalogMetaService.java
Show resolved
Hide resolved
core/src/test/java/com/datastrato/gravitino/storage/relational/TestRelationalEntityStore.java
Show resolved
Hide resolved
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
2 times, most recently
from
5ebec02 to
9aa6056
Compare
xloya
force-pushed
the
add-mysql-backend-ops-for-catalog
branch
from
9aa6056 to
70a91d0
Compare
yuqi1129
reviewed
Feb 28, 2024
| if (re.getCause() != null | ||
| && re.getCause().getCause() != null | ||
| && re.getCause().getCause() instanceof SQLIntegrityConstraintViolationException) { | ||
| // TODO We should make more fine-grained exception judgments |
There was a problem hiding this comment.
It would be best to create an issue to track it at this point. The current implementation is not aesthetically pleasing.
There was a problem hiding this comment.
Had created the issue before: #2227
|
Could you also assist in taking a look? @qqqttt123 |
LGTM. |
+1 @jerryshao , do you have any further comments? |
I don't have further comment, you can go ahead if you feel ok @yuqi1129 . |
jerryshao
pushed a commit
that referenced
this pull request
Mar 4, 2024
### What changes were proposed in this pull request? The purpose of this PR is to implement JDBC backend operation Schema metadata. Depend on #2078 . Metadata operations of Table and Fileset will be supported in the remaining PRs. ### Why are the changes needed? Fix: #2082 ### How was this patch tested? Add unit tests to test the schema metadata ops. --------- Co-authored-by: xiaojiebao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The purpose of this PR is to implement JDBC backend operation
Catalogmetadata. Depend on #1980 . Metadata operations of Schema, Table and Fileset will be supported in the remaining PRs.Why are the changes needed?
Fix: #2081
How was this patch tested?
Add unit tests to test the catalog metadata ops.