Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Improve the judgment granularity of exception information in JDBC backend #2227

Closed
Tracked by #1811
xloya opened this issue Feb 18, 2024 · 3 comments · Fixed by #2862
Closed
Tracked by #1811

[Improvement] Improve the judgment granularity of exception information in JDBC backend #2227

xloya opened this issue Feb 18, 2024 · 3 comments · Fixed by #2862
Assignees
@xloya
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@xloya
Copy link
Contributor

xloya commented Feb 18, 2024

What would you like to be improved?

Improve the judgment granularity of exception information of different databases in JDBC backend, current method of tracking exception classes is too coarse-grained and requires fine-grained judgment. see #1980 (comment)

How should we improve?

No response
@xloya xloya added the improvement Improvements on everything label Feb 18, 2024
@xloya xloya mentioned this issue Feb 18, 2024
Merged
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Feb 20, 2024
This was referenced Feb 28, 2024
Merged
Closed
@yuqi1129
Copy link
Contributor

yuqi1129 commented Apr 9, 2024

@xloya
Do you have time to work on it in release 0.5.0?

@xloya
Copy link
Contributor Author

xloya commented Apr 10, 2024

@xloya Do you have time to work on it in release 0.5.0?

@yuqi1129 Not yet. I'll try my best.

@yuqi1129
Copy link
Contributor

OK, If you do not have time, we can postpone it to release 0.5.1 or later since it's just an improvement.

@xloya xloya mentioned this issue Apr 10, 2024
Merged
yuqi1129 pushed a commit that referenced this issue Apr 14, 2024
@xloya
[#2227] improvement(jdbc-backend): Improve the judgment of exception …
9128db0 
…information in JDBC backend (#2862)

### What changes were proposed in this pull request?

Determine exceptions more accurately based on SQL Exception error codes.

### Why are the changes needed?

Fix: #2227

### How was this patch tested?

Add the unit tests.

---------

Co-authored-by: xiaojiebao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xloya xloya

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
3 participants
@jerryshao @yuqi1129 @xloya