[#2080] feat(core): Add JDBC backend operations for metalake #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
changed the title
|
In this PR, Mybatis is used as the ORM framework to implement complex joint queries through SQL in the future, and transaction management can be performed well. |
xloya
force-pushed
the
add-mysql-backend-ops-for-metalake
branch
2 times, most recently
from
9a8389b to
92ca94b
Compare
|
@jerryshao @yuqi1129 @coolderli This PR is ready for review, please take a look when you have time, thanks! |
xloya
force-pushed
the
add-mysql-backend-ops-for-metalake
branch
4 times, most recently
from
4594fe2 to
1fc8cd0
Compare
xloya
force-pushed
the
add-mysql-backend-ops-for-metalake
branch
from
1fc8cd0 to
3442dbe
Compare
qqqttt123
reviewed
Feb 5, 2024
10 tasks
xloya
changed the title
xloya
force-pushed
the
add-mysql-backend-ops-for-metalake
branch
2 times, most recently
from
eb4164e to
fde3c14
Compare
qqqttt123
reviewed
Feb 6, 2024
qqqttt123
reviewed
Feb 6, 2024
common/src/main/java/com/datastrato/gravitino/json/JsonUtils.java
Outdated
Show resolved
Hide resolved
xloya
force-pushed
the
add-mysql-backend-ops-for-metalake
branch
3 times, most recently
from
0010748 to
2512912
Compare
qqqttt123
reviewed
Feb 6, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/mysql/MySQLBackend.java
Outdated
Show resolved
Hide resolved
.../java/com/datastrato/gravitino/storage/relational/mysql/session/SqlSessionFactoryHelper.java
Outdated
Show resolved
Hide resolved
qqqttt123
changed the title
qqqttt123
reviewed
Feb 6, 2024
qqqttt123
reviewed
Feb 6, 2024
...c/main/java/com/datastrato/gravitino/storage/relational/mysql/mapper/MetalakeMetaMapper.java
Outdated
Show resolved
Hide resolved
|
@xloya Thanks for your PR. |
yuqi1129
reviewed
Feb 6, 2024
common/src/main/java/com/datastrato/gravitino/json/JsonUtils.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/mysql/MySQLBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/mysql/MySQLBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/mysql/MySQLBackend.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Feb 6, 2024
xloya
force-pushed
the
add-mysql-backend-ops-for-metalake
branch
3 times, most recently
from
2b2aef4 to
0faa6ec
Compare
xloya
force-pushed
the
add-mysql-backend-ops-for-metalake
branch
from
0faa6ec to
7760554
Compare
|
@xloya , overall LGTM, I have no further comment, we can update anything missing in the follow-up PRs. |
jerryshao
approved these changes
Feb 26, 2024
|
Thanks @qqqttt123 @yuqi1129 @jerryshao @diqiu50 @YxAc @coolderli @justinmclean for your reviews! |
yuqi1129
pushed a commit
that referenced
this pull request
Feb 28, 2024
### What changes were proposed in this pull request? The purpose of this PR is to implement JDBC backend operation `Catalog` metadata. Depend on #1980 . Metadata operations of Schema, Table and Fileset will be supported in the remaining PRs. ### Why are the changes needed? Fix: #2081 ### How was this patch tested? Add unit tests to test the catalog metadata ops. --------- Co-authored-by: xiaojiebao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The purpose of this PR is to implement JDBC backend operation Metalake metadata which use MySQL as the database. Depend on #1930. Metadata operations of Catalog, Schema, Table and Fileset will be supported in the remaining PRs.
Why are the changes needed?
Fix: #2080
How was this patch tested?
Add unit tests to test the metalake metadata ops.