[#2079] feat(relation-entity-store): Add the relation entity store interface #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerryshao @yuqi1129 @coolderli Please take a look when you have time, thanks! |
xloya
force-pushed
the
add-rel-store-interface
branch
from
d3ce370 to
a3e18a1
Compare
yuqi1129
reviewed
Feb 3, 2024
core/src/main/java/com/datastrato/gravitino/storage/relation/RelationBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relation/mysql/MysqlBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relation/RelationEntityStore.java
Outdated
Show resolved
Hide resolved
xloya
force-pushed
the
add-rel-store-interface
branch
2 times, most recently
from
0ddbc53 to
82e18e0
Compare
|
@jerryshao @yuqi1129 Fixed as per comments, please take a look again when you have time, thanks! |
coolderli
reviewed
Feb 4, 2024
core/src/main/java/com/datastrato/gravitino/storage/relation/RelationEntityStore.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Feb 5, 2024
qqqttt123
reviewed
Feb 5, 2024
core/src/main/java/com/datastrato/gravitino/storage/relation/RelationBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relation/RelationBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relation/RelationBackend.java
Outdated
Show resolved
Hide resolved
10 tasks
xloya
changed the title
jerryshao
reviewed
Feb 5, 2024
jerryshao
reviewed
Feb 5, 2024
core/src/main/java/com/datastrato/gravitino/storage/relation/RelationEntityStore.java
Outdated
Show resolved
Hide resolved
xloya
force-pushed
the
add-rel-store-interface
branch
2 times, most recently
from
76243d4 to
3f46e1b
Compare
qqqttt123
reviewed
Feb 6, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/RelationalEntityStore.java
Outdated
Show resolved
Hide resolved
xloya
force-pushed
the
add-rel-store-interface
branch
from
3f46e1b to
23945b7
Compare
|
@jerryshao @qqqttt123 @yuqi1129 @coolderli The comments have been fixed. Please help to review again when you have time, thanks |
|
LGTM, @yuqi1129 @jerryshao Could you give further suggestion? |
jerryshao
reviewed
Feb 6, 2024
jerryshao
reviewed
Feb 6, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/RelationalEntityStore.java
Show resolved
Hide resolved
jerryshao
pushed a commit
that referenced
this pull request
Feb 26, 2024
### What changes were proposed in this pull request? The purpose of this PR is to implement JDBC backend operation Metalake metadata which use MySQL as the database. Depend on #1930. Metadata operations of Catalog, Schema, Table and Fileset will be supported in the remaining PRs. ### Why are the changes needed? Fix: #2080 ### How was this patch tested? Add unit tests to test the metalake metadata ops. --------- Co-authored-by: xiaojiebao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The purpose of this PR is to add the interface of relational entity store, and the Mysql backend will be implemented in the next PR.
Why are the changes needed?
Fix: #2079