[#2082] feat(core): Add JDBC backend operations for schema #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
commented
Feb 28, 2024
xloya
force-pushed
the
add-ops-for-schema
branch
from
342c1b7 to
1d10a0f
Compare
|
@yuqi1129 This PR is ready for review, please take a look when you have time, thanks! |
yuqi1129
reviewed
Feb 29, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/SchemaMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/storage/relational/service/SchemaMetaService.java
Outdated
Show resolved
Hide resolved
|
@jerryshao @yuqi1129 @qqqttt123 Have fixed the comments, please take a look again when you have time. Hope we can finish the reviews of the remaining PRs today, thanks! |
|
@qqqttt123 |
qqqttt123
reviewed
Mar 1, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/SchemaMetaService.java
Show resolved
Hide resolved
|
Generally LGTM, just some nits. |
qqqttt123
reviewed
Mar 1, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/SchemaMetaService.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Mar 1, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/SchemaMetaService.java
Outdated
Show resolved
Hide resolved
|
@yuqi1129 @qqqttt123 Any further comment for this? Thanks! |
qqqttt123
reviewed
Mar 1, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CommonMetaService.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Mar 1, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CommonMetaService.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Mar 1, 2024
core/src/main/java/com/datastrato/gravitino/storage/relational/service/CommonMetaService.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 1, 2024 17:47
|
LGTM. Let @yuqi1129 take a final look. |
jerryshao
pushed a commit
that referenced
this pull request
Mar 5, 2024
### What changes were proposed in this pull request? The purpose of this PR is to implement JDBC backend operation for Table metadata. Depend on #2377 . Metadata operations of Fileset will be supported in the remaining PRs. ### Why are the changes needed? Fix: #2083 ### How was this patch tested? Add unit tests to test the table metadata ops. --------- Co-authored-by: xiaojiebao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The purpose of this PR is to implement JDBC backend operation Schema metadata. Depend on #2078 . Metadata operations of Table and Fileset will be supported in the remaining PRs.
Why are the changes needed?
Fix: #2082
How was this patch tested?
Add unit tests to test the schema metadata ops.