Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor](log) Delete useless logics checking #41589

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[minor](log) Delete useless logics checking #41589

merged 1 commit into from
Oct 9, 2024

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40401 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d0ccc1b3ffcc6b23434ae4b6733db0b5332c76d6, data reload: false

------ Round 1 ----------------------------------
q1	17601	7368	7273	7273
q2	2018	278	270	270
q3	12199	1052	1136	1052
q4	10553	764	651	651
q5	7742	2847	2784	2784
q6	240	150	155	150
q7	998	638	614	614
q8	9366	1930	1869	1869
q9	6466	6427	6411	6411
q10	6940	2316	2309	2309
q11	441	242	243	242
q12	409	211	212	211
q13	17780	2986	2977	2977
q14	231	204	210	204
q15	566	533	527	527
q16	652	587	566	566
q17	971	582	651	582
q18	7239	6684	6784	6684
q19	1352	1048	962	962
q20	475	199	191	191
q21	4040	2903	3166	2903
q22	1102	969	1011	969
Total cold run time: 109381 ms
Total hot run time: 40401 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7279	7284	7231	7231
q2	328	240	233	233
q3	2931	2925	2966	2925
q4	2027	1900	1883	1883
q5	5766	5700	5754	5700
q6	228	150	145	145
q7	2191	1893	1839	1839
q8	3356	3610	3438	3438
q9	8989	8931	8930	8930
q10	3595	3577	3534	3534
q11	570	497	501	497
q12	842	599	646	599
q13	10361	3189	3172	3172
q14	315	280	279	279
q15	577	520	525	520
q16	701	651	643	643
q17	1866	1608	1605	1605
q18	8160	7566	7698	7566
q19	1719	1558	1624	1558
q20	2104	1860	1936	1860
q21	5484	5166	5392	5166
q22	1129	1001	1022	1001
Total cold run time: 70518 ms
Total hot run time: 60324 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191647 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d0ccc1b3ffcc6b23434ae4b6733db0b5332c76d6, data reload: false

query1	944	400	414	400
query2	6297	2083	1988	1988
query3	8684	191	195	191
query4	34128	23518	23572	23518
query5	3516	469	477	469
query6	259	173	170	170
query7	4210	310	318	310
query8	293	226	229	226
query9	9601	2684	2683	2683
query10	458	280	288	280
query11	17690	15158	15116	15116
query12	156	95	99	95
query13	1566	474	448	448
query14	8598	7624	7175	7175
query15	260	169	174	169
query16	7540	466	416	416
query17	1616	616	581	581
query18	2054	348	346	346
query19	392	152	154	152
query20	123	108	110	108
query21	226	109	104	104
query22	4761	4775	4573	4573
query23	34705	34398	34254	34254
query24	10966	2855	2785	2785
query25	627	414	399	399
query26	1483	161	166	161
query27	2494	291	299	291
query28	7681	2431	2404	2404
query29	910	435	430	430
query30	262	154	153	153
query31	1038	797	818	797
query32	98	56	54	54
query33	765	305	297	297
query34	911	527	504	504
query35	862	740	729	729
query36	1106	944	937	937
query37	158	90	88	88
query38	4055	3928	3861	3861
query39	1483	1411	1392	1392
query40	265	99	99	99
query41	48	45	44	44
query42	122	96	95	95
query43	525	488	477	477
query44	1291	815	829	815
query45	197	162	162	162
query46	1123	720	700	700
query47	1943	1853	1851	1851
query48	430	370	357	357
query49	1008	414	397	397
query50	809	422	413	413
query51	7233	6829	6942	6829
query52	96	89	91	89
query53	254	181	202	181
query54	1348	461	458	458
query55	79	73	78	73
query56	268	263	257	257
query57	1249	1162	1154	1154
query58	227	223	240	223
query59	3138	2938	2885	2885
query60	301	276	273	273
query61	111	107	105	105
query62	897	661	679	661
query63	224	185	185	185
query64	4956	662	623	623
query65	3516	3226	3205	3205
query66	1415	307	327	307
query67	15771	15577	15755	15577
query68	4447	585	558	558
query69	500	286	289	286
query70	1215	1127	1135	1127
query71	371	267	272	267
query72	7244	3694	3959	3694
query73	791	342	349	342
query74	9895	9020	9031	9020
query75	3437	2709	2667	2667
query76	3044	981	976	976
query77	490	286	289	286
query78	10375	9534	9557	9534
query79	2076	592	590	590
query80	1111	431	447	431
query81	592	240	244	240
query82	702	134	134	134
query83	241	132	139	132
query84	264	74	78	74
query85	1443	296	281	281
query86	413	294	292	292
query87	4400	4330	4251	4251
query88	3582	2434	2388	2388
query89	412	291	284	284
query90	1998	185	180	180
query91	157	111	105	105
query92	60	47	47	47
query93	2097	552	551	551
query94	1077	288	276	276
query95	357	252	244	244
query96	625	283	277	277
query97	3238	3108	3086	3086
query98	212	194	193	193
query99	1512	1295	1285	1285
Total cold run time: 300198 ms
Total hot run time: 191647 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d0ccc1b3ffcc6b23434ae4b6733db0b5332c76d6, data reload: false

query1	0.04	0.04	0.02
query2	0.06	0.03	0.03
query3	0.22	0.06	0.06
query4	1.65	0.10	0.10
query5	0.52	0.50	0.49
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.03	0.03	0.04
query9	0.58	0.49	0.49
query10	0.55	0.54	0.55
query11	0.14	0.11	0.12
query12	0.14	0.12	0.11
query13	0.62	0.60	0.61
query14	2.82	2.72	2.73
query15	0.90	0.82	0.82
query16	0.39	0.42	0.39
query17	1.00	1.04	1.05
query18	0.20	0.20	0.19
query19	1.94	1.77	1.97
query20	0.01	0.01	0.01
query21	15.38	0.59	0.60
query22	2.76	2.72	1.82
query23	17.06	1.09	0.75
query24	3.36	0.98	0.80
query25	0.32	0.21	0.13
query26	0.27	0.14	0.14
query27	0.04	0.04	0.03
query28	10.96	1.09	1.06
query29	12.56	3.24	3.20
query30	0.24	0.06	0.06
query31	2.87	0.38	0.39
query32	3.28	0.46	0.47
query33	3.01	2.96	3.05
query34	17.06	4.41	4.44
query35	4.53	4.47	4.48
query36	0.69	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.83 s
Total hot run time: 32.28 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9630/25835)
Line Coverage: 28.67% (79853/278567)
Region Coverage: 28.10% (41284/146920)
Branch Coverage: 24.72% (21034/85074)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d0ccc1b3ffcc6b23434ae4b6733db0b5332c76d6_d0ccc1b3ffcc6b23434ae4b6733db0b5332c76d6/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit fc0279b into apache:master Oct 9, 2024
25 of 29 checks passed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@Gabriel39 @eldenmoon
[minor](log) Delete useless logics checking (apache#41589)
dce80cb
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 11, 2024
@Gabriel39
[minor](log) Delete useless logics checking (apache#41589)
355463c
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 11, 2024
@Gabriel39
[minor](log) Delete useless logics checking (apache#41589)
9eaa7b1
This was referenced Oct 11, 2024
Closed
Merged
Gabriel39 added a commit that referenced this pull request Oct 11, 2024
@Gabriel39
[branch-3.0](pick) Pick 6 commits (#41715)
8260737 
pick #39982 #41292 #40576 #41555 #41589 #41592
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@Gabriel39 @cjj2010
[minor](log) Delete useless logics checking (apache#41589)
14b4eaa
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@Gabriel39 @amorynan
[minor](log) Delete useless logics checking (apache#41589)
b3d6f24
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 16, 2024
@Gabriel39
[minor](log) Delete useless logics checking (apache#41589)
00baec5
@Gabriel39 Gabriel39 mentioned this pull request Oct 16, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 16, 2024
@Gabriel39 @BiteTheDDDDt
[pick](branch-2.1) pick #41292 #41350 #41589 #41628 #41743 #41601 #41667
5bd33fc 
 #41751 (#41927)

## Proposed changes

pick #41292 #41350 #41589 #41628 #41743 #41601 #41667 #41751

<!--Describe your changes.-->

---------

Co-authored-by: Pxl <[email protected]>
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 17, 2024
@Gabriel39
[minor](log) Delete useless logics checking (apache#41589)
bfb9490
@Gabriel39 Gabriel39 mentioned this pull request Oct 17, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 17, 2024
@Gabriel39 @BiteTheDDDDt
[pick](branch-3.0) pick #41292 #41589 #41628 #41743 #41845 #41857 #41902
9066903 
 #41601 #41667 #41751 (#42031)

pick #41292 #41589 #41628 #41743 #41845 #41857 #41902 #41601 #41667
#41751

Co-authored-by: Pxl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mryange Mryange Mryange approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @BiteTheDDDDt @Mryange