-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](pipeline) Refactor pipeline execution #39982
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -231,7 +231,8 @@ Status AnalyticSinkOperatorX::init(const TPlanNode& tnode, RuntimeState* state) | |||
return Status::OK(); | |||
} | |||
|
|||
Status AnalyticSinkOperatorX::prepare(RuntimeState* state) { | |||
Status AnalyticSinkOperatorX::open(RuntimeState* state) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method 'open' can be made const [readability-make-member-function-const]
Status AnalyticSinkOperatorX::open(RuntimeState* state) { | |
Status AnalyticSinkOperatorX::open(RuntimeState* state) const { |
be/src/pipeline/exec/analytic_sink_operator.h:76:
- Status open(RuntimeState* state) override;
+ Status open(RuntimeState* state) const override;
TPC-H: Total hot run time: 37957 ms
|
TPC-DS: Total hot run time: 186525 ms
|
ClickBench: Total hot run time: 30.98 s
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H: Total hot run time: 37824 ms
|
TPC-DS: Total hot run time: 192503 ms
|
ClickBench: Total hot run time: 30.82 s
|
4bd8676
to
ef351e7
Compare
run buildall |
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38602 ms
|
TPC-DS: Total hot run time: 192414 ms
|
ClickBench: Total hot run time: 31.82 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Unify `prepare` and `open` in `Operator`.
Unify `prepare` and `open` in `Operator`.
Proposed changes
Unify
prepare
andopen
inOperator
.