Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](followup) Stop tasks if waken by downstream tasks #41628

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[fix](followup) Stop tasks if waken by downstream tasks #41628

merged 1 commit into from
Oct 11, 2024

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Oct 9, 2024 •
edited
Loading

Proposed changes

Follow-up : #41292

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39 Gabriel39 changed the title [fix](pipeline) Stop execution if task is finished [fix](followup) Stop tasks if waken by downstream tasks Oct 10, 2024
@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Oct 10, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.41% (9663/25828)
Line Coverage: 28.70% (80197/279467)
Region Coverage: 28.12% (41455/147399)
Branch Coverage: 24.72% (21106/85392)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e8975dc36a3c1f3a67b9c3b11fdef05114a5c923_e8975dc36a3c1f3a67b9c3b11fdef05114a5c923/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.41% (9663/25827)
Line Coverage: 28.69% (80175/279483)
Region Coverage: 28.12% (41455/147417)
Branch Coverage: 24.73% (21117/85402)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6a99137de860e5a515b58ca87aec50c03eca9f83_6a99137de860e5a515b58ca87aec50c03eca9f83/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.40% (9661/25829)
Line Coverage: 28.68% (80173/279507)
Region Coverage: 28.11% (41449/147462)
Branch Coverage: 24.71% (21105/85426)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6a99137de860e5a515b58ca87aec50c03eca9f83_6a99137de860e5a515b58ca87aec50c03eca9f83/report/index.html

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Oct 11, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.40% (9659/25827)
Line Coverage: 28.67% (80141/279530)
Region Coverage: 28.10% (41441/147469)
Branch Coverage: 24.71% (21109/85432)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d47f827dda8534ebbd12ab1afac577d1bf0a56d5_d47f827dda8534ebbd12ab1afac577d1bf0a56d5/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@Gabriel39 Gabriel39 merged commit 1e72755 into apache:master Oct 11, 2024
24 of 26 checks passed
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 16, 2024
@Gabriel39
[fix](followup) Stop tasks if waken by downstream tasks (apache#41628)
dd9d7ee 
Follow-up : apache#41292
@Gabriel39 Gabriel39 mentioned this pull request Oct 16, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 16, 2024
@Gabriel39 @BiteTheDDDDt
[pick](branch-2.1) pick #41292 #41350 #41589 #41628 #41743 #41601 #41667
5bd33fc 
 #41751 (#41927)

## Proposed changes

pick #41292 #41350 #41589 #41628 #41743 #41601 #41667 #41751

<!--Describe your changes.-->

---------

Co-authored-by: Pxl <[email protected]>
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 17, 2024
@Gabriel39
[fix](followup) Stop tasks if waken by downstream tasks (apache#41628)
121537d 
Follow-up : apache#41292
@Gabriel39 Gabriel39 mentioned this pull request Oct 17, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 17, 2024
@Gabriel39 @BiteTheDDDDt
[pick](branch-3.0) pick #41292 #41589 #41628 #41743 #41845 #41857 #41902
9066903 
 #41601 #41667 #41751 (#42031)

pick #41292 #41589 #41628 #41743 #41845 #41857 #41902 #41601 #41667
#41751

Co-authored-by: Pxl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mryange Mryange Mryange approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @BiteTheDDDDt @Mryange