Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor](log) Add debug log #41857

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[minor](log) Add debug log #41857

merged 2 commits into from
Oct 15, 2024

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9709/25916)
Line Coverage: 28.73% (80591/280490)
Region Coverage: 28.18% (41699/147965)
Branch Coverage: 24.76% (21206/85634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f2a42b0ff57c2fd705b5047fc1ff19178f1a9730_f2a42b0ff57c2fd705b5047fc1ff19178f1a9730/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9709/25916)
Line Coverage: 28.74% (80615/280494)
Region Coverage: 28.19% (41706/147965)
Branch Coverage: 24.76% (21203/85634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f2a42b0ff57c2fd705b5047fc1ff19178f1a9730_f2a42b0ff57c2fd705b5047fc1ff19178f1a9730/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41510 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cb2940b0d0312d2ff67782c07bf1852680358fd, data reload: false

------ Round 1 ----------------------------------
q1	17611	7526	7381	7381
q2	2057	163	156	156
q3	10577	1137	1179	1137
q4	10237	854	889	854
q5	7738	3177	3090	3090
q6	244	152	151	151
q7	1012	618	611	611
q8	9607	1989	2005	1989
q9	8151	6441	6456	6441
q10	7192	2432	2435	2432
q11	437	247	247	247
q12	512	217	218	217
q13	17799	3002	3029	3002
q14	240	229	207	207
q15	573	548	514	514
q16	659	592	584	584
q17	984	574	594	574
q18	7525	6776	6691	6691
q19	1339	1028	1009	1009
q20	484	190	193	190
q21	4069	3032	3142	3032
q22	1088	1001	1006	1001
Total cold run time: 110135 ms
Total hot run time: 41510 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7331	7320	7338	7320
q2	333	229	225	225
q3	2964	2829	2826	2826
q4	1993	1761	1722	1722
q5	5490	5510	5548	5510
q6	225	145	147	145
q7	2147	1751	1742	1742
q8	3254	3404	3453	3404
q9	8597	8621	8634	8621
q10	3484	3464	3461	3461
q11	587	499	491	491
q12	790	597	562	562
q13	13633	3003	3024	3003
q14	292	269	264	264
q15	568	516	515	515
q16	665	647	641	641
q17	1867	1574	1577	1574
q18	7750	7466	7371	7371
q19	1674	1492	1476	1476
q20	2080	1830	1827	1827
q21	5447	5390	5241	5241
q22	1104	1051	1011	1011
Total cold run time: 72275 ms
Total hot run time: 58952 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9707/25916)
Line Coverage: 28.73% (80575/280495)
Region Coverage: 28.18% (41691/147965)
Branch Coverage: 24.76% (21204/85634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9cb2940b0d0312d2ff67782c07bf1852680358fd_9cb2940b0d0312d2ff67782c07bf1852680358fd/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191944 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cb2940b0d0312d2ff67782c07bf1852680358fd, data reload: false

query1	940	379	386	379
query2	4352	2151	2049	2049
query3	1949	217	218	217
query4	32595	23606	23491	23491
query5	2785	487	470	470
query6	222	161	174	161
query7	3355	293	298	293
query8	278	226	227	226
query9	6753	2771	2746	2746
query10	417	275	289	275
query11	17804	15326	15272	15272
query12	153	103	104	103
query13	1189	444	408	408
query14	9549	7340	7349	7340
query15	246	168	179	168
query16	6944	441	445	441
query17	1156	564	564	564
query18	1936	303	311	303
query19	243	152	147	147
query20	118	110	114	110
query21	147	105	105	105
query22	4646	4239	4395	4239
query23	34923	34211	34213	34211
query24	12169	2761	2809	2761
query25	637	416	397	397
query26	1544	169	159	159
query27	2388	283	281	281
query28	6537	2446	2419	2419
query29	878	430	430	430
query30	332	162	152	152
query31	1029	828	843	828
query32	98	57	57	57
query33	672	292	314	292
query34	918	524	536	524
query35	899	758	770	758
query36	1083	946	950	946
query37	192	91	91	91
query38	4031	3925	3997	3925
query39	1542	1442	1416	1416
query40	282	102	102	102
query41	49	48	46	46
query42	124	101	96	96
query43	537	484	481	481
query44	1232	852	834	834
query45	202	167	174	167
query46	1143	715	742	715
query47	1965	1830	1849	1830
query48	418	317	333	317
query49	1152	445	429	429
query50	839	388	397	388
query51	7315	7070	6916	6916
query52	102	91	85	85
query53	252	183	184	183
query54	653	429	441	429
query55	79	80	77	77
query56	278	289	266	266
query57	1287	1148	1148	1148
query58	250	270	265	265
query59	3292	3158	2945	2945
query60	320	282	288	282
query61	163	100	101	100
query62	840	696	673	673
query63	222	186	181	181
query64	4933	649	591	591
query65	3272	3243	3256	3243
query66	1361	307	326	307
query67	16241	15518	15565	15518
query68	4558	563	549	549
query69	462	287	299	287
query70	1206	1078	1105	1078
query71	330	289	276	276
query72	5833	3993	4009	3993
query73	782	352	369	352
query74	9551	8935	9097	8935
query75	3385	2683	2676	2676
query76	2537	887	905	887
query77	410	297	295	295
query78	10590	9633	9623	9623
query79	1141	584	587	584
query80	1820	449	440	440
query81	573	250	240	240
query82	434	141	136	136
query83	276	136	137	136
query84	258	71	70	70
query85	1436	282	278	278
query86	370	293	298	293
query87	4432	4317	4264	4264
query88	3188	2222	2163	2163
query89	396	289	288	288
query90	2142	183	184	183
query91	140	102	104	102
query92	64	50	49	49
query93	1071	541	533	533
query94	1172	280	295	280
query95	353	252	244	244
query96	620	281	287	281
query97	3311	3156	3182	3156
query98	220	205	196	196
query99	1645	1349	1309	1309
Total cold run time: 281158 ms
Total hot run time: 191944 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.14 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cb2940b0d0312d2ff67782c07bf1852680358fd, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.65	0.11	0.10
query5	0.53	0.49	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.03	0.03	0.02
query9	0.56	0.50	0.50
query10	0.56	0.56	0.55
query11	0.15	0.11	0.10
query12	0.14	0.11	0.13
query13	0.61	0.59	0.60
query14	2.72	2.74	2.73
query15	0.89	0.82	0.84
query16	0.39	0.39	0.38
query17	1.02	1.01	0.97
query18	0.24	0.22	0.22
query19	1.97	1.86	2.01
query20	0.01	0.01	0.01
query21	15.35	0.57	0.57
query22	2.38	2.87	1.89
query23	16.92	1.10	0.81
query24	2.92	1.76	1.42
query25	0.19	0.06	0.08
query26	0.68	0.14	0.13
query27	0.06	0.05	0.04
query28	10.28	1.10	1.06
query29	12.56	3.23	3.23
query30	0.25	0.06	0.06
query31	2.89	0.38	0.37
query32	3.27	0.46	0.46
query33	2.95	3.02	3.08
query34	16.84	4.47	4.47
query35	4.51	4.49	4.51
query36	0.67	0.47	0.48
query37	0.08	0.06	0.05
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.11 s
Total hot run time: 33.14 s

HappenLee
HappenLee approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 1e5c758 into apache:master Oct 15, 2024
24 of 27 checks passed
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 15, 2024
@Gabriel39
[minor](log) Add debug log (apache#41857)
7293247
@Gabriel39 Gabriel39 mentioned this pull request Oct 15, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 15, 2024
@Gabriel39
[pick](branch-2.1) pick #41676 #41740 #41857 (#41904)
b185dfc 
pick #41676 #41740 #41857
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 17, 2024
@Gabriel39
[minor](log) Add debug log (apache#41857)
26b0f7c
@Gabriel39 Gabriel39 mentioned this pull request Oct 17, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 17, 2024
@Gabriel39 @BiteTheDDDDt
[pick](branch-3.0) pick #41292 #41589 #41628 #41743 #41845 #41857 #41902
9066903 
 #41601 #41667 #41751 (#42031)

pick #41292 #41589 #41628 #41743 #41845 #41857 #41902 #41601 #41667
#41751

Co-authored-by: Pxl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @yiguolei @HappenLee