Add timezone support to JSON reader #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 11, 2023
| @@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {} | |||
| impl ArrowTemporalType for DurationNanosecondType {} | |||
|
|
|||
| /// A timestamp type allows us to create array builders that take a timestamp. | |||
| pub trait ArrowTimestampType: ArrowTemporalType { | |||
| pub trait ArrowTimestampType: ArrowTemporalType<Native = i64> { | |||
There was a problem hiding this comment.
This is not a breaking change as these types are sealed, but it simplifies generic code as i64 is guaranteed
There was a problem hiding this comment.
I don't understand how these are sealed -- https://docs.rs/arrow/35.0.0/arrow/datatypes/trait.ArrowTimestampType.html
Maybe we should add a doc commen note here explaining that they are sealed
There was a problem hiding this comment.
Oh, I assumed they were, they definitely should be 😄
alamb
approved these changes
Mar 17, 2023
| @@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {} | |||
| impl ArrowTemporalType for DurationNanosecondType {} | |||
|
|
|||
| /// A timestamp type allows us to create array builders that take a timestamp. | |||
| pub trait ArrowTimestampType: ArrowTemporalType { | |||
| pub trait ArrowTimestampType: ArrowTemporalType<Native = i64> { | |||
There was a problem hiding this comment.
I don't understand how these are sealed -- https://docs.rs/arrow/35.0.0/arrow/datatypes/trait.ArrowTimestampType.html
Maybe we should add a doc commen note here explaining that they are sealed
spebern
pushed a commit
to spebern/arrow-rs
that referenced
this pull request
Mar 25, 2023
* Add timezone support to JSON reader * Fix doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?