-
Notifications
You must be signed in to change notification settings - Fork 785
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add timezone support to JSON reader (#3845)
* Add timezone support to JSON reader * Fix doc
- Loading branch information
Showing
5 changed files
with
169 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
use chrono::TimeZone; | ||
use num::NumCast; | ||
use std::marker::PhantomData; | ||
|
||
use arrow_array::builder::PrimitiveBuilder; | ||
use arrow_array::types::ArrowTimestampType; | ||
use arrow_array::Array; | ||
use arrow_cast::parse::string_to_datetime; | ||
use arrow_data::ArrayData; | ||
use arrow_schema::{ArrowError, DataType, TimeUnit}; | ||
|
||
use crate::raw::tape::{Tape, TapeElement}; | ||
use crate::raw::{tape_error, ArrayDecoder}; | ||
|
||
/// A specialized [`ArrayDecoder`] for timestamps | ||
pub struct TimestampArrayDecoder<P: ArrowTimestampType, Tz: TimeZone> { | ||
data_type: DataType, | ||
timezone: Tz, | ||
// Invariant and Send | ||
phantom: PhantomData<fn(P) -> P>, | ||
} | ||
|
||
impl<P: ArrowTimestampType, Tz: TimeZone> TimestampArrayDecoder<P, Tz> { | ||
pub fn new(data_type: DataType, timezone: Tz) -> Self { | ||
Self { | ||
data_type, | ||
timezone, | ||
phantom: Default::default(), | ||
} | ||
} | ||
} | ||
|
||
impl<P, Tz> ArrayDecoder for TimestampArrayDecoder<P, Tz> | ||
where | ||
P: ArrowTimestampType, | ||
Tz: TimeZone + Send, | ||
{ | ||
fn decode(&mut self, tape: &Tape<'_>, pos: &[u32]) -> Result<ArrayData, ArrowError> { | ||
let mut builder = PrimitiveBuilder::<P>::with_capacity(pos.len()) | ||
.with_data_type(self.data_type.clone()); | ||
|
||
for p in pos { | ||
match tape.get(*p) { | ||
TapeElement::Null => builder.append_null(), | ||
TapeElement::String(idx) => { | ||
let s = tape.get_string(idx); | ||
let date = string_to_datetime(&self.timezone, s).map_err(|e| { | ||
ArrowError::JsonError(format!( | ||
"failed to parse \"{s}\" as {}: {}", | ||
self.data_type, e | ||
)) | ||
})?; | ||
|
||
let value = match P::UNIT { | ||
TimeUnit::Second => date.timestamp(), | ||
TimeUnit::Millisecond => date.timestamp_millis(), | ||
TimeUnit::Microsecond => date.timestamp_micros(), | ||
TimeUnit::Nanosecond => date.timestamp_nanos(), | ||
}; | ||
builder.append_value(value) | ||
} | ||
TapeElement::Number(idx) => { | ||
let s = tape.get_string(idx); | ||
let value = lexical_core::parse::<f64>(s.as_bytes()) | ||
.ok() | ||
.and_then(NumCast::from) | ||
.ok_or_else(|| { | ||
ArrowError::JsonError(format!( | ||
"failed to parse {s} as {}", | ||
self.data_type | ||
)) | ||
})?; | ||
|
||
builder.append_value(value) | ||
} | ||
d => return Err(tape_error(d, "primitive")), | ||
} | ||
} | ||
|
||
Ok(builder.finish().into_data()) | ||
} | ||
} |