Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read temporal values from JSON #38

Closed
Tracked by #3148
alamb opened this issue Apr 26, 2021 · 4 comments
Closed
Tracked by #3148

Read temporal values from JSON #38

alamb opened this issue Apr 26, 2021 · 4 comments
Labels
arrow Changes to the arrow crate

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-4803

Ability to parse strings that look like timestamps to timestamp type. Need to consider whether only timestamp type should be supported as most JSON libraries stick to ISO8601. It might also be inefficient to use regex for timestamps, so the user should provide a hint of which columns to convert to timestamps

@alamb alamb added the arrow Changes to the arrow crate label Apr 26, 2021
@sum12
Copy link
Contributor

sum12 commented Jan 6, 2022

It seems the behavior here is not consistent. TemporalValues can get parsed to u64 if they look like u64 otherwise it is a null, but only while dealing with build_struct_array whereas for build_nested_list_array an error is returned.

It could be done as done in csv_reader with regex and extra strings describing possible formats. Or we could have parser as closures (eg : Fn(String) -> Type)) stored in the reader/decoder(/Schema?)

@sum12
Copy link
Contributor

sum12 commented Jan 10, 2022

@alamb I would like to take a stab at this one (if it is still relevant)
Thanks for looking :-)

@alamb
Copy link
Contributor Author

alamb commented Jan 10, 2022

As @nevi-me filed the original ticket, he may have some additional context. Thanks @sum12 !

@tustvold
Copy link
Contributor

tustvold commented Mar 16, 2023

Closed by #3835 with further support in #3845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

No branches or pull requests

3 participants