Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1.0.0 libraries release (tracking issue) #1490

Closed
19 of 26 tasks
lidavidm opened this issue Jan 24, 2024 · 18 comments · Fixed by #1762
Closed
19 of 26 tasks

feat: 1.0.0 libraries release (tracking issue) #1490

lidavidm opened this issue Jan 24, 2024 · 18 comments · Fixed by #1762

Comments

@lidavidm
Copy link
Member

lidavidm commented Jan 24, 2024

Broadly:

  • Include C#/.NET in releases
  • Bring drivers on par with each other roughly (particularly for PostgreSQL and SQLite, which are extremely divergent codebases)
  • Ensure more functional and correctness testing
  • Ensure some basic performance testing

Rust is being explicitly punted on without a contributor.

Hopefully this would be what would be 0.12.0 or 0.13.0 (roughly, Summer 2024)

This isn't a complete list of tasks, just me scanning the backlog of things I think would be good to get done and adding a couple more thoughts.

Bindings

Documentation

Drivers

Arrow Flight SQL

JDBC Adapter

PostgreSQL

Snowflake

SQLite3

@jduo
Copy link
Member

jduo commented Jan 24, 2024

Would updating to Arrow 15 be part of this?

@CurtHagenlocher
Copy link
Contributor

Do we think that this would be with the existing 1.1 specification or should we also consider any items in #8 as targets for a 1.2 spec and 1.0 release?

@lidavidm
Copy link
Member Author

Would updating to Arrow 15 be part of this?

@jduo this isn't a complete list, I didn't list general maintenance tasks (Arrow 15 I expect to happen for the next release)

Do we think that this would be with the existing 1.1 specification or should we also consider any items in #8 as targets for a 1.2 spec and 1.0 release?

I think it would extend the timeline but if there is interest we should start drafting the proposal.

@judahrand
Copy link
Contributor

Would it be reasonable to add handling prepared statements for Postgres to this release?

@lidavidm
Copy link
Member Author

lidavidm commented Feb 9, 2024

@judahrand would you mind filing an issue about what's missing so I can link it here? (I know the support is incomplete but it's been a while since I've dug into the implementation)

@lidavidm
Copy link
Member Author

lidavidm commented Feb 9, 2024

Ah now I see the other comments you've made

@lidavidm
Copy link
Member Author

lidavidm commented Feb 9, 2024

I linked #81 and #855 but if you'd still like to file an issue with more details I can link it here too

@lidavidm lidavidm pinned this issue Feb 9, 2024
@lidavidm
Copy link
Member Author

lidavidm commented Mar 1, 2024

Removing #1143 because it needs upstream support first.

@xinyiZzz
Copy link

Would Spark and Flink have their own driver? thanks.

I found an open source spark-flight-connector, but it has not update for a long time.
(https://github.com/qwshen/spark-flight-connector)

I saw that Dremio introduced a plugin in 2023, it allow hive/spark to read and write Dremio. I hope Apache Doris can also have this capability.
(https://george-jen.gitbook.io/data-science-and-apache-spark/dremio-data-lake-engine-apache-arrow-flight-connector-with-spark-machine-learning, https://github.com/dremio-hub/dremio-flight-connector)

@lidavidm
Copy link
Member Author

If people are willing to contribute drivers for Spark/Flink, that may be possible. That will not happen for 1.0.0.

@xinyiZzz
Copy link

ok, thanks reply.

If people are willing to contribute drivers for Spark/Flink, that may be possible. That will not happen for 1.0.0.

@lidavidm lidavidm added this to the ADBC Libraries 1.0.0 milestone Apr 4, 2024
@lidavidm
Copy link
Member Author

I've added to the discussion on dev@ about versioning given I'd like to put out 1.0.0 releases of some components here (Snowflake, Flight SQL, SQLite) but not everything else (PostgreSQL still needs some work, I believe, and the Java bindings are just too untested). It would mean refactoring the release scripts and the next couple releases would probably take a good deal of manual work, though.

@CurtHagenlocher
Copy link
Contributor

It would be good to iron out the exact scope of what a 1.0.0 would include. I'd like (for instance) to make some breaking changes to some C# APIs to clean them up a bit but I've been putting that off as lower priority. I also want to implement the 1.1 spec. So if 1.0.0 is going to include some of the C# components then I'll need to get to work... .

CC: @davidhcoe

@lidavidm
Copy link
Member Author

Okay. I'll give breaking up versioning a shot since I don't want to rush you into that work.

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
@lidavidm
Copy link
Member Author

I started on this in #1762 so C# will be 0.12.0. That way we can move to 1.0.0 whenever you feel the API is ready and there's no rush on your side. Testing this out pre-release is going to be a bit of a pain, but that's alright.

@kou you've already seen it but I'll be counting on you for review/よろしくお願いします 🙏

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
@kou
Copy link
Member

kou commented Apr 25, 2024

Sure! I'll review #1762 carefully!

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Apr 25, 2024
lidavidm added a commit that referenced this issue Apr 29, 2024
Start refactoring our release process so that we can theoretically
handle different version numbers in different language subprojects.

Fixes #1490.

---------

Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
@lidavidm lidavidm unpinned this issue Apr 29, 2024
@lidavidm
Copy link
Member Author

While there are still issues listed in the parent, I don't think anything is exactly a blocker. I'd like to kick off the release either at the end of the week or at the start of next week. (5/3-5/6)

@lidavidm
Copy link
Member Author

@paleolimbot I've currently marked R packages to have a next version number of "0.12.0", but we can make it "1.0.0" if you'd like

cocoa-xu pushed a commit to meowcraft-dev/arrow-adbc that referenced this issue May 8, 2024
Start refactoring our release process so that we can theoretically
handle different version numbers in different language subprojects.

Fixes apache#1490.

---------

Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants