Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c: make build warning-clean on MSVC #847

Closed
Tracked by #1490
lidavidm opened this issue Jun 24, 2023 · 2 comments · Fixed by #1600
Closed
Tracked by #1490

c: make build warning-clean on MSVC #847

lidavidm opened this issue Jun 24, 2023 · 2 comments · Fixed by #1600
Milestone
ADBC Libraries 0....

Comments

@lidavidm
Copy link
Member

No description provided.

@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Jun 24, 2023
@paleolimbot paleolimbot mentioned this issue Jun 25, 2023
Merged
lidavidm pushed a commit that referenced this issue Jun 25, 2023
@paleolimbot
chore(c/vendor): Update vendored nanoarrow (#850)
0696bcf 
It seems like an older version may be causing problems with MSVC
warnings (#847,
#844 (comment) ).
@lidavidm
Copy link
Member Author

OK, this isn't possible still...

IMO, we suppress these:

  • C4061: MSVC wants us to handle each case explicitly in a switch.
  • C4100: unused parameters
  • C4820: padding added to a struct

That just leaves:

  • C4242, C4244, C4267: implicit conversions
  • C4996: use of strerror (MSVC recommends strerror_s which is C11+)

@lidavidm
Copy link
Member Author

We may want to macro-wrap strerror/strerror_s

@lidavidm lidavidm removed this from the ADBC Libraries 0.9.0 milestone Dec 19, 2023
@lidavidm lidavidm mentioned this issue Jan 24, 2024
Closed
26 tasks
@lidavidm lidavidm added this to the ADBC Libraries 0.11.0 milestone Mar 4, 2024
@lidavidm lidavidm mentioned this issue Mar 8, 2024
Merged
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 8, 2024
@lidavidm
build(c): fix warnings for MSVC
500eaf9 
Fixes apache#847.
@lidavidm lidavidm mentioned this issue Mar 8, 2024
Merged
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 8, 2024
@lidavidm
build(c): fix warnings for MSVC
d90614b 
Fixes apache#847.
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 8, 2024
@lidavidm
build(c): fix warnings for MSVC
4576fe9 
Fixes apache#847.
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 8, 2024
@lidavidm
build(c): fix warnings for MSVC
24aff35 
Fixes apache#847.
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 8, 2024
@lidavidm
build(c): fix warnings for MSVC
f01f0b5 
Fixes apache#847.
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 8, 2024
@lidavidm
build(c): fix warnings for MSVC
d3b273b 
Fixes apache#847.
lidavidm added a commit that referenced this issue Mar 8, 2024
@lidavidm
build(c): fix warnings for MSVC (#1600)
0b50e4f 
This leaves warnings about dllexport/dllimport which will require
further investigation.

Fixes #847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.11.0
Development

Successfully merging a pull request may close this issue.

build(c): fix warnings for MSVC lidavidm/arrow-adbc
1 participant
@lidavidm