Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c: fix include paths for adbc.h #1150

Closed
Tracked by #1490
lidavidm opened this issue Oct 2, 2023 · 2 comments · Fixed by #1965
Closed
Tracked by #1490

c: fix include paths for adbc.h #1150

lidavidm opened this issue Oct 2, 2023 · 2 comments · Fixed by #1965
Assignees
@ywc88
Milestone
ADBC Libraries 14

Comments

@lidavidm
Copy link
Member

lidavidm commented Oct 2, 2023

We've been using #include <adbc.h> but we should be nice and use something like #include <arrow-adbc/adbc.h>
@lidavidm lidavidm added this to the ADBC Libraries 0.8.0 milestone Oct 2, 2023
@ywc88 ywc88 self-assigned this Oct 5, 2023
@lidavidm lidavidm removed this from the ADBC Libraries 0.9.0 milestone Dec 19, 2023
@rtadepalli
Copy link
Contributor

What's the preferred way forward here? I'm working on adding a new arrow-adbc directory under c/ -- want to confirm once that this is ok (does seem like the only way to do this though, unless I'm missing something).

@lidavidm
Copy link
Member Author

lidavidm commented Jan 9, 2024

I think that is the only way, yes. Thank you.

@lidavidm lidavidm mentioned this issue Jan 24, 2024
Closed
26 tasks
@lidavidm lidavidm added this to the ADBC Libraries 1.0.0 milestone Apr 4, 2024
@lidavidm lidavidm removed this from the ADBC Libraries 1.0.0 milestone Apr 23, 2024
@WillAyd WillAyd mentioned this issue Jul 3, 2024
Merged
@github-actions github-actions bot added this to the ADBC Libraries 14 milestone Jul 3, 2024
lidavidm pushed a commit that referenced this issue Jul 30, 2024
@WillAyd @paleolimbot
refactor(c)!: Updated include/install paths for adbc.h (#1965)
8fb7c2f 
closes #1150

---------

Co-authored-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywc88 ywc88

Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 14
Development

Successfully merging a pull request may close this issue.

refactor(c)!: Updated include/install paths for adbc.h WillAyd/arrow-adbc
3 participants
@lidavidm @rtadepalli @ywc88