Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/adbc/driver/snowflake: Parameterized SQL queries -> NotSupportedError #1144

Closed
Tracked by #1490
matquant14 opened this issue Oct 2, 2023 · 3 comments · Fixed by #1808
Closed
Tracked by #1490

go/adbc/driver/snowflake: Parameterized SQL queries -> NotSupportedError #1144

matquant14 opened this issue Oct 2, 2023 · 3 comments · Fixed by #1808
Assignees
@lidavidm
Milestone
ADBC Libraries 12

Comments

@matquant14
Copy link

Using the python Snowflake driver, when trying to execute a parameterized SQL query, I am getting a 'NotSupportedError'.

Example:

sql="""SELECT * FROM customer where id = ?;"""
parameter=('ABCD',)
cursor = conn.cursor()

cursor.execute(sql,parameter)

Traceback...
NotSupportedError: NOT_IMPLEMENTED: executing non-bulk ingest with bound params not yet implemented

I'm using python 3.11.5 and adbc 0.7.0
@lidavidm
Copy link
Member

lidavidm commented Oct 2, 2023

As the error message indicates, it's just not implemented in the Snowflake driver yet.

@matquant14
Copy link
Author

matquant14 commented Oct 2, 2023 •
edited
Loading

From what i can tell, the snowflake driver is using the Cursor from adbc_driver_manager.

Unless i missed it somewhere, the documentation doesn't say it's only currently implemented for data ingestion, not extraction.

https://arrow.apache.org/adbc/current/python/api/adbc_driver_manager.html#adbc_driver_manager.dbapi.Cursor.execute

Is there any timetable for when it will be implemented?

@lidavidm
Copy link
Member

lidavidm commented Oct 2, 2023

I don't think anyone is actively working on it; contributions are welcome.

@sezaru sezaru mentioned this issue Oct 20, 2023
Closed
@alexander-beedie alexander-beedie mentioned this issue Nov 26, 2023
Closed
@lidavidm lidavidm mentioned this issue Jan 24, 2024
Closed
26 tasks
@lidavidm lidavidm changed the title python: Parameterized SQL queries -> NotSupportedError go/adbc/driver/snowflake: Parameterized SQL queries -> NotSupportedError Jan 24, 2024
@lidavidm lidavidm added this to the ADBC Libraries 1.0.0 milestone Apr 4, 2024
@lidavidm lidavidm self-assigned this May 2, 2024
lidavidm added a commit that referenced this issue May 3, 2024
@lidavidm
feat(go/adbc/driver/snowflake): support parameter binding
e1553dd 
Fixes #1144.
@lidavidm lidavidm mentioned this issue May 3, 2024
Merged
lidavidm added a commit that referenced this issue May 3, 2024
@lidavidm
feat(go/adbc/driver/snowflake): support parameter binding
47302ec 
Fixes #1144.
lidavidm added a commit that referenced this issue May 3, 2024
@lidavidm
feat(go/adbc/driver/snowflake): support parameter binding
22c5d4a 
Fixes #1144.
lidavidm added a commit that referenced this issue May 3, 2024
@lidavidm
Merge branch 'gh-1804' into gh-1144
18d753b
lidavidm added a commit that referenced this issue May 3, 2024
@lidavidm
Merge branch 'gh-1804' into gh-1144
aeca9c9
lidavidm added a commit that referenced this issue May 4, 2024
@lidavidm
feat(go/adbc/driver/snowflake): support parameter binding
c134295 
Fixes #1144.
lidavidm added a commit that referenced this issue May 7, 2024
@lidavidm
feat(go/adbc/driver/snowflake): support parameter binding (#1808)
8f0bdb3 
Fixes #1144.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 12
Development

Successfully merging a pull request may close this issue.

feat(go/adbc/driver/snowflake): support parameter binding apache/arrow-adbc
2 participants
@lidavidm @matquant14