Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Instance Group Form to use Slider when available #7777

Closed
nixocio opened this issue Jul 30, 2020 · 10 comments
Closed

Update Instance Group Form to use Slider when available #7777

nixocio opened this issue Jul 30, 2020 · 10 comments
Assignees
@nixocio @one-t
Labels
component:ui type:feature prioritized on a feature board

Comments

@nixocio
Copy link
Contributor

nixocio commented Jul 30, 2020 •
edited
Loading

ISSUE TYPE

  • Feature Idea
SUMMARY

Once slider component is available update Instance Group Form to use this one.

Mock up: https://tower-mockups.testing.ansible.com/patternfly/instance-groups/instance-groups-add/

See: patternfly/patternfly#296

Also: patternfly/patternfly-react#5187
@nixocio
Copy link
Contributor Author

nixocio commented Jul 30, 2020

See: #7776

@nixocio nixocio mentioned this issue Oct 1, 2020
Closed
@marshmalien
Copy link
Member

Status Update:
The Slider component is currently scheduled for PatternFly's 02.17.2021 release date, but we trying to get the Slider pulled into their 01.28.2021 release. Will continue to monitor.

@nixocio nixocio self-assigned this Nov 16, 2020
@marshmalien
Copy link
Member

Slider added to PF-React here: patternfly/patternfly-react#5358

@AlexSCorey AlexSCorey mentioned this issue Feb 9, 2021
Closed
@nixocio nixocio mentioned this issue Feb 9, 2021
Closed
nixocio added a commit to nixocio/awx that referenced this issue Feb 9, 2021
@nixocio
Update Patternfly to allow access to slider component
92c01a1 
Update Patternfly to allow access to slider component

See: ansible#7777
@nixocio nixocio mentioned this issue Feb 9, 2021
Merged
nixocio added a commit to nixocio/awx that referenced this issue Feb 10, 2021
@nixocio
Update Patternfly to allow access to slider component
bd61d3c 
Update Patternfly to allow access to slider component

See: ansible#7777
nixocio added a commit to nixocio/awx that referenced this issue Feb 12, 2021
@nixocio
Update Patternfly to allow access to slider component
3b2e9d7 
Update Patternfly to allow access to slider component

See: ansible#7777
jakemcdermott pushed a commit to jakemcdermott/awx that referenced this issue Feb 16, 2021
@nixocio @jakemcdermott
Update Patternfly to allow access to slider component
02c8f4c 
Update Patternfly to allow access to slider component

See: ansible#7777
@mabashian
Copy link
Member

Lets hold off on this for a bit

@nixocio
Copy link
Contributor Author

nixocio commented Apr 6, 2021

After feedback from @shanemcd, it was decided to use the same implementation details from the old ui.

@unlikelyzero
Copy link

@nixocio will this get the new slider component from patternfly?

@nixocio
Copy link
Contributor Author

nixocio commented Apr 8, 2021

@nixocio will this get the new slider component from patternfly?

That is the idea.

@unlikelyzero
Copy link

@one-t, do you mind taking this one? I know you have some extensive experience here

@nixocio
Copy link
Contributor Author

nixocio commented Apr 12, 2021

I started working on this issue, and I realized that there is a newer version of this component.

image

And this new version seems to be affected by this patternfly/patternfly-react#5464

I will explore a few solutions for the time being.

nixocio added a commit to nixocio/awx that referenced this issue Apr 30, 2021
@nixocio
Add slider to adjust capacity_adjustment
a01e212 
Add slider to adjust capacity adjustment.

Also add a new custom hook, useDebounce.

See: ansible#7777
@nixocio nixocio mentioned this issue Apr 30, 2021
Merged
nixocio added a commit to nixocio/awx that referenced this issue May 4, 2021
@nixocio
Add slider to adjust capacity_adjustment
1dd1e4e 
Add slider to adjust capacity adjustment.

Also add a new custom hook, useDebounce.

See: ansible#7777
nixocio added a commit to nixocio/awx that referenced this issue May 5, 2021
@nixocio
Add slider to adjust capacity_adjustment
a10d015 
Add slider to adjust capacity adjustment.

Also add a new custom hook, useDebounce.

See: ansible#7777
nixocio added a commit to nixocio/awx that referenced this issue May 10, 2021
@nixocio
Add slider to adjust capacity_adjustment
e6e7031 
Add slider to adjust capacity adjustment.

Also add a new custom hook, useDebounce.

See: ansible#7777
nixocio added a commit to nixocio/awx that referenced this issue May 12, 2021
@nixocio
Add slider to adjust capacity_adjustment
dfb0710 
Add slider to adjust capacity adjustment.

Also add a new custom hook, useDebounce.

See: ansible#7777
softwarefactory-project-zuul bot added a commit that referenced this issue May 12, 2021
@softwarefactory-project-zuul
Merge pull request #10063 from nixocio/ui_issue_7777_style
27b1d15 
Add slider to adjust capacity_adjustment

Add slider to adjust capacity adjustment.
Also add a new custom hook, useDebounce.

See: #7777

Reviewed-by: Kersom <None>
Reviewed-by: Alex Corey <[email protected]>
Reviewed-by: Keith Grant <[email protected]>
Reviewed-by: Tiago Góes <[email protected]>
@tiagodread
Copy link
Contributor

PR already merged

djedy99 pushed a commit to djedy99/awx that referenced this issue Apr 19, 2024
@nixocio
Update PF to allow access to slider component
d0d3311 
Update PF to allow access to slider component.

See: ansible/awx#7777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nixocio nixocio

@one-t one-t

Labels
component:ui type:feature prioritized on a feature board
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ryanpetrello @wenottingham @nixocio @mabashian @unlikelyzero @tiagodread @marshmalien @one-t