Add slider to adjust capacity_adjustment #10063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixocio
requested review from
mabashian,
marshmalien,
keithjgrant and
AlexSCorey
nixocio
commented
Apr 30, 2021
| <div data-cy="number-forks"> | ||
| <Plural value={forks} one="# fork" other="# forks" /> | ||
| </div> | ||
| <Slider |
There was a problem hiding this comment.
Slider does not support ouiaId yet. @tiagodread I added data-cy in order to ease testing. Let me know whether they are good enough.
|
Running e2e tests. |
|
Build succeeded.
|
AlexSCorey
requested changes
May 3, 2021
| @@ -352,7 +352,7 @@ You can learn more about the ways lingui and its React helpers at [this link](ht | |||
| ### Setting up .po files to give to translation team | |||
|
|
|||
| 1. `npm run add-locale` to add the language that you want to translate to (we should only have to do this once and the commit to repo afaik). Example: `npm run add-locale en es fr` # Add English, Spanish and French locale | |||
| 2. `npm run extract-strings` to create .po files for each language specified. The .po files will be placed in src/locales. When updating strings that are used by `<Plural>` or `plural()` you will need to run this command to get the strings to render properly. This commmand will create `.po` files for each of the supported languages that will need to be commited with your PR. | |||
| 2. `npm run extract-strings` to create .po files for each language specified. The .po files will be placed in src/locales. When updating strings that are used by `<Plural>` or `plural()` you will need to run this command to get the strings to render properly. This command will create `.po` files for each of the supported languages that will need to be committed with your PR. | |||
awx/ui_next/src/screens/InstanceGroup/Instances/InstanceListItem.test.jsx
Show resolved
Hide resolved
nixocio
force-pushed
the
ui_issue_7777_style
branch
from
a01e212 to
1dd1e4e
Compare
I followed with @trahman73 about the alignment used on the mockups, his feedback - All components should be vertically aligned on the middle. Updated accordingly.
|
|
Build succeeded.
|
keithjgrant
reviewed
May 4, 2021
nixocio
force-pushed
the
ui_issue_7777_style
branch
from
1dd1e4e to
a10d015
Compare
|
Build succeeded.
|
keithjgrant
approved these changes
May 5, 2021
nixocio
force-pushed
the
ui_issue_7777_style
branch
from
a10d015 to
e6e7031
Compare
|
Build succeeded.
|
tiagodread
approved these changes
May 12, 2021
|
@nixocio we can merge this PR after a rebase |
Add slider to adjust capacity adjustment. Also add a new custom hook, useDebounce. See: ansible#7777
nixocio
force-pushed
the
ui_issue_7777_style
branch
from
e6e7031 to
dfb0710
Compare
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add slider to adjust capacity adjustment.
Also add a new custom hook, useDebounce.
See: #7777