Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Patternfly to allow access to slider component #9277

Merged

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Feb 9, 2021

Update Patternfly to allow access to slider component

See: #7777

@nixocio
Copy link
Contributor Author

nixocio commented Feb 9, 2021

Running e2e tests.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@jakemcdermott jakemcdermott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If E2E and visuals are happy, I am happy.

@unlikelyzero
Copy link

After meeting with @nixocio , the only issue we found was that the YAML/JSON toggles were too large
Screen Shot 2021-02-10 at 9 01 40 AM

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@unlikelyzero
Copy link

@nixocio were you able to fix the visual bug?
Screen Shot 2021-02-13 at 11 54 53 AM

@nixocio
Copy link
Contributor Author

nixocio commented Feb 13, 2021

@nixocio were you able to fix the visual bug?
Screen Shot 2021-02-13 at 11 54 53 AM

I think so, I will verify the last visual test run.

Verified with @unlikelyzero, failure was fixed.

Update Patternfly to allow access to slider component

See: ansible#7777
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0df85b0 into ansible:devel Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants