Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to add instance group #7776

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Add feature to add instance group #7776

merged 1 commit into from
Aug 10, 2020

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Jul 30, 2020 •
edited
Loading

Add feature to add instance group.

See: #7744

image

@nixocio nixocio mentioned this pull request Jul 30, 2020
Closed
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

jlmitch5
jlmitch5 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! just check with Taufique/Tvo on the help text language if it is different from the old ui and you haven't already

@nixocio nixocio force-pushed the ui_add_instance_group branch from bc1c5eb to b896385 Compare August 3, 2020 14:05
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nixocio
Copy link
Contributor Author

nixocio commented Aug 3, 2020

Thanks for your review @jlmitch5, text updated per feedback provided by Taufique/Tvo.

@dsesami dsesami self-requested a review August 4, 2020 18:32
@nixocio nixocio added the mergeit label Aug 7, 2020
@nixocio nixocio force-pushed the ui_add_instance_group branch from b896385 to 78a76f0 Compare August 7, 2020 16:09
@ansible ansible deleted a comment from softwarefactory-project-zuul bot Aug 7, 2020
@nixocio
Copy link
Contributor Author

nixocio commented Aug 7, 2020

recheck

1 similar comment
@dsesami
Copy link
Contributor

dsesami commented Aug 7, 2020

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@nixocio
Copy link
Contributor Author

nixocio commented Aug 10, 2020

recheck

@nixocio
Copy link
Contributor Author

nixocio commented Aug 10, 2020

regate

@nixocio
Add feature to add instance group
897c8b7 
Add feature to add instance group.

See: ansible#7744
@nixocio nixocio force-pushed the ui_add_instance_group branch from 78a76f0 to 897c8b7 Compare August 10, 2020 17:07
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@nixocio
Copy link
Contributor Author

nixocio commented Aug 10, 2020

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fbb9998 into ansible:devel Aug 10, 2020
@mabashian mabashian mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsesami dsesami dsesami approved these changes

@jlmitch5 jlmitch5 jlmitch5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nixocio @dsesami @jlmitch5