Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow targets should only be wrapped in a list once #1097

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Slow targets should only be wrapped in a list once #1097

merged 1 commit into from
Sep 7, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 6, 2021

We're currently seeing 'slow' tests double-wrapped in a list, this is breaking things:

  "for_zuul_return": {
    "data": {
      "child": {
        "targets_to_test": [
          [   
            [   
              "ec2_vpc_subnet"
            ]   
          ],  
          [   
            [   
              "ec2_vol"
            ]   
          ],  
          [   
            [   
              "ec2_ami"
            ]   
          ],  
          [   
            [   
              "ec2_eni"
            ]   
          ],  
          [   
            "aws_caller_info",
            "aws_s3",
            "lookup_aws_account_attribute",
            "ec2_elb_lb",
            "ec2_vpc_igw",
            "ec2",
            "inventory_aws_ec2",
            "module_utils_core",
            "ec2_key",
            "s3_bucket",
            "cloudformation",
            "ec2_vpc_dhcp_option",
            "module_utils_waiter"
          ],  
          [
            "ec2_metadata_facts",
            "ec2_spot_instance",
            "aws_az_info",
            "ec2_vpc_endpoint_service_info",
            "ec2_vpc_route_table",
            "inventory_aws_rds",
            "ec2_tag",
            "ec2_vpc_nat_gateway",
            "ec2_vpc_net",
            "lookup_aws_secret",
            "lookup_aws_service_ip_ranges",
            "module_utils_ec2"
          ]
        ]
      },
      "zuul": {
        "child_jobs": [
          "ansible-test-cloud-integration-aws-py36_0",
          "ansible-test-cloud-integration-aws-py36_1",
          "ansible-test-cloud-integration-aws-py36_2",
          "ansible-test-cloud-integration-aws-py36_3",
          "ansible-test-cloud-integration-aws-py36_4",
          "ansible-test-cloud-integration-aws-py36_5"
        ]
      }
    }
  }
}

This was referenced Sep 6, 2021
Merged
Merged
@tremble
Copy link
Contributor Author

tremble commented Sep 6, 2021

@goneri

@tremble tremble mentioned this pull request Sep 6, 2021
Merged
This was referenced Sep 7, 2021
Closed
Closed
@goneri goneri added the gate label Sep 7, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goneri
Copy link
Collaborator

goneri commented Sep 7, 2021

Thank you Mark!

@ansible-zuul ansible-zuul bot merged commit f68e34a into ansible:master Sep 7, 2021
ansible-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Sep 8, 2021
@tremble
Backport - Fixup / ignore new pylint 2.9.3 issues (#460) (#491)
f309a46 
Backport - Fixup / ignore new pylint 2.9.3 issues

SUMMARY
The containers have been updated to include a new version of pylint ( ansible-collections/overview#45 )
fixup arguments-renamed
ignore pylint:use-a-generator (an easy fix but not worth blocking gating)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tests/unit/mock/loader.py
tests/unit/module_utils/test_elbv2.py
ADDITIONAL INFORMATION
Backport of #460
Depends-On: ansible/ansible-zuul-jobs#1097

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
ansible-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Sep 28, 2021
@tremble
ec2_elb_lb boto3 migration (#377)
0d790f6 
ec2_elb_lb boto3 migration

SUMMARY
Rewrite ec2_elb_lb using the boto3 SDK
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_elb_lb
ADDITIONAL INFORMATION
Current state

 renamed to elb_classic_lb
 create/delete ELBs
 change schema
 update availability-zones
 update subnets
 manage tags
 manage listeners
 manage health checks
 manage cross-AZ balancing
 manage draining
 manage idle_timeout
 manage backend policies
 manage stickiness
 manage Instance attachment
 manage access logging
 lookup SGs by name
 parameter validation (protocol, mandatory on creation etc)

Depends-On: ansible/ansible-zuul-jobs#1097

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@goneri goneri goneri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @goneri