Backport - Fixup / ignore new pylint 2.9.3 issues #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#460) The devel containers have been updated to include a new version of pylint ( ansible-collections/overview#45 (comment) ) fixup arguments-renamed ignore pylint:use-a-generator (Should be an easy fix but not worth blocking gating)
ansibullbot
added
bug
This was referenced Sep 6, 2021
|
recheck |
1 similar comment
|
recheck |
tremble
force-pushed
the
backport/1.5/460
branch
from
f2e9e58 to
81c1186
Compare
|
recheck |
1 similar comment
|
recheck |
alinabuzachis
approved these changes
Sep 8, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
#371) (#479) ec2_vol: backport to stable-1.5 to fix modify_volume size option bug SUMMARY Back port to stable-1.5 to fix a bug in modify_volume, 'size' option. Fixes #471. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION Required fix was done but was not applied in 1.5.0 release. For more details, please visit #471. Backports: #371 Depends-On: #491 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
ansible-zuul bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
ec2_vol: backport fix incorrectly returned changed result SUMMARY Backport version of #483 When modify_volume is used but no new disk is being attached, the module incorrectly reports that no change has occurred even when disks have been modified (iops, throughput, type, etc.). This is due to the attach function overwriting the changed variable even if no disks are attached. Fixes #482 The integration test has been fixed so that when the gp3 modifications are tested, the volume is already in an attached state (previously detached) when reporting back changed. The detach tests are moved further down now, allowing this case to be properly covered by the existing assert: amazon.aws/tests/integration/targets/ec2_vol/tasks/tests.yml Lines 384 to 387 in e8df917 - name: check that volume_type has changed assert: that: - changed_gp3_volume.changed ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol Depends-On: #491 Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Fix cloudfront_distribution disabling ipv6 when updating resource Reviewed-by: https://github.com/apps/ansible-zuul
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Fix cloudfront_distribution disabling ipv6 when updating resource Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The containers have been updated to include a new version of pylint ( ansible-collections/overview#45 )
fixup arguments-renamed
ignore pylint:use-a-generator (an easy fix but not worth blocking gating)
ISSUE TYPE
COMPONENT NAME
tests/unit/mock/loader.py
tests/unit/module_utils/test_elbv2.py
ADDITIONAL INFORMATION
Backport of #460
Depends-On: ansible/ansible-zuul-jobs#1097