Fixup / ignore new pylint 2.9.3 issues #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
…and not worth blocking gating
felixfontein
approved these changes
Aug 12, 2021
|
recheck |
|
(yet another ec2_vol flake) |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
alinabuzachis
approved these changes
Aug 12, 2021
|
gate failure was a known flake - should be fixed by #455 and ansible-collections/community.aws#681 |
|
recheck |
This was referenced Aug 12, 2021
Merged
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 23, 2021
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 25, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 25, 2021
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4f8c366
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 25, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 25, 2021
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4f8c366
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 25, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 25, 2021
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4f8c366
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
that referenced
this pull request
Aug 26, 2021
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4f8c366
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 26, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 26, 2021
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 26, 2021
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Aug 26, 2021
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Sep 6, 2021
…s#460) The devel containers have been updated to include a new version of pylint ( ansible-collections/overview#45 (comment) ) fixup arguments-renamed ignore pylint:use-a-generator (Should be an easy fix but not worth blocking gating)
ansible-zuul bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
Backport - Fixup / ignore new pylint 2.9.3 issues SUMMARY The containers have been updated to include a new version of pylint ( ansible-collections/overview#45 ) fixup arguments-renamed ignore pylint:use-a-generator (an easy fix but not worth blocking gating) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/unit/mock/loader.py tests/unit/module_utils/test_elbv2.py ADDITIONAL INFORMATION Backport of #460 Depends-On: ansible/ansible-zuul-jobs#1097 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Apr 20, 2022
ec2_key : Fix tests SUMMARY The Zuul nodes don't have OpenSSL installed on them, this breaks the generation of the fingerprints ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_key ADDITIONAL INFORMATION https://dashboard.zuul.ansible.com/t/ansible/build/d79dcec2e3024558800bba5fd6917505/log/job-output.txt "stderr": "/bin/sh: line 1: openssl: command not found" Depends-on: ansible-collections#460 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> (cherry picked from commit 963a829)
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog.
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog.
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog.
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The devel containers have been updated to include a new version of pylint ( ansible-collections/overview#45 (comment) )
fixup arguments-renamed
fixup "raise None"
ignore pylint:use-a-generator (Should be an easy fix but not worth blocking gating)
ISSUE TYPE
COMPONENT NAME
plugins/modules/ec2_instance.py
tests/sanity/ignore-2.12.txt
tests/unit/mock/loader.py
tests/unit/module_utils/test_elbv2.py
tests/unit/module_utils/test_s3.py
ADDITIONAL INFORMATION