-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_elb_lb boto3 migration #377
ec2_elb_lb boto3 migration #377
Conversation
e4f95ef
to
b59106a
Compare
This comment has been minimized.
This comment has been minimized.
following up on our irc convo, I'm +1 to ec2_classic_lb with redirects (the ec2 classic announcements read like classic ELBs will also be retired, but I'm skimming quickly so I could have missed something) |
ec11588
to
15fc9ce
Compare
15fc9ce
to
6f98a2b
Compare
This comment has been minimized.
This comment has been minimized.
6f98a2b
to
d50fe50
Compare
6b2a0d6
to
c1e29d2
Compare
@jillr I've re-added the 'fact' (for what little a hard-coded value is worth). As such we should be able to land this in a normal minor release rather than this needing to wait for a major release. There are a couple of similar 'facts' over in community.aws that we should probably prune at the same time we clean out all of the _fact aliases, and just have 3.0 labeled as our big "fact" cleanup. |
This comment has been minimized.
This comment has been minimized.
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this seems good to me! Thank you @tremble, the review took more than I expected.
plugins/modules/elb_classic_lb.py
Outdated
description: | ||
- Creates, updates or destroys an Amazon Elastic Load Balancer (ELB). | ||
- This module was renamed from M(ec2_elb_lb) to M(elb_classic_lb) in version | ||
2.0.0 of the amazon.aws collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.0.0 of the amazon.aws collection. | |
2.1.0 of the amazon.aws collection. |
We missed 2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
elb_classic_lb - deprecate the ec2_elb fact SUMMARY deprecates the ec2_elb fact in favour of the elb return value. Split off from #377 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_classic_lb ADDITIONAL INFORMATION (yes, this module set a fact with the same name, but different content, as the elb_instance module.) Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
elb_classic_lb - Remove deprecated ec2_elb fact SUMMARY Remove previously deprecated ec2_elb fact from elb_classic_lb this only every returned the value 'info'. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_classic_lb ADDITIONAL INFORMATION See also #552 and #377 for some of the history. Reviewed-by: Alina Buzachis <None>
SUMMARY
Rewrite ec2_elb_lb using the boto3 SDK
ISSUE TYPE
COMPONENT NAME
ec2_elb_lb
ADDITIONAL INFORMATION
Current state
Depends-On: ansible/ansible-zuul-jobs#1097