Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable support for setting SSL policies for all ELB modules #696

Closed
1 task done
gtie opened this issue Aug 23, 2021 · 5 comments
Closed
1 task done

Enable support for setting SSL policies for all ELB modules #696

gtie opened this issue Aug 23, 2021 · 5 comments
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)

Comments

@gtie
Copy link

gtie commented Aug 23, 2021

Summary

See ansible/ansible#18918

Issue Type

Feature Idea

Component Name

ec2_elb, ec2_elb_lb, ec2_elb_facts

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @markuman @mjschultz @nand0p @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Aug 23, 2021
@tremble
Copy link
Contributor

tremble commented Aug 23, 2021

@gtie, Thanks for taking the time to submit this suggestion.

If anyone was interested in doing this, then I'd recommend a dedicated module. I'm currently working on migrating ec2_elb_lb (aka elb_classic_lb) to the 'latest' AWS SDK (from boto to boto3) ansible-collections/amazon.aws#377 and at this point the single module manages so much that properly testing the module is very slow.

alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@jatorcasso
elbv2 module_util - support alb attributes and add compare method for…
b14e392 
… check_mode (ansible-collections#696)

elbv2 module_util - support alb attributes and add compare method for check_mode

SUMMARY

Add support for modifying alb specific attributes for ansible-collections#963
Add compare_elb_attributes method to support check_mode

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

community.aws.elb_application_lb
amazon/aws/plugins/module_utils/elbv2.py

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
@alinabuzachis
Copy link
Contributor

@tremble can we close this?

@tremble
Copy link
Contributor

tremble commented Sep 28, 2022

elb_classic_lb supports SSL, so I'd say yes.

@tremble tremble closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tremble @gtie @alinabuzachis @ansibullbot