Resolve black and sanity errors #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
Add sanity ignore for ansible 2.14 Pin black and click packages
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
build failures are hitting disk out of space issues. I don't have access to vexxhost so rechecking until I get a good node. |
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add sanity ignore for ansible 2.14 and upgrade black version
ISSUE TYPE
COMPONENT NAME
tox.ini
tests/ignores/sanity-2.14.txt
This would supersede #313 and #314
ADDITIONAL INFO
Versions of
blacknewer than 19.x introduce formatting changes that will need to be incorporated into the generated modules before we can check against those versions in CIhttps://black.readthedocs.io/en/stable/change_log.html#id61
Changes in
clickrequireblack>=22.3.0.psf/black#2964
For now let's pin both at what works.