Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and pin black version #314

Closed
wants to merge 1 commit into from

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Apr 7, 2022

SUMMARY

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tox.ini

Signed-off-by: Abhijeet Kasurde <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Akasurde Akasurde requested a review from goneri April 7, 2022 14:34
@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Andersson007
Copy link
Contributor

hello folks, any updates on the PR?

@jillr
Copy link
Collaborator

jillr commented Apr 22, 2022

Resolved in 317

@jillr jillr closed this Apr 22, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 22, 2022
Resolve black and sanity errors

SUMMARY
Add sanity ignore for ansible 2.14 and upgrade black version
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tox.ini
tests/ignores/sanity-2.14.txt
This would supersede #313 and #314
ADDITIONAL INFO
Versions of black newer than 19.x introduce formatting changes that will need to be incorporated into the generated modules before we can check against those versions in CI
https://black.readthedocs.io/en/stable/change_log.html#id61
Changes in click require black>=22.3.0.
psf/black#2964
For now let's pin both at what works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants