Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
there are unrelated failings, could anyone from maintainers take a look? Thanks |
|
@Andersson007 Thanks for the PR. Black related errors is fixed via #314 |
|
@Akasurde thanks for the quick response! |
|
recheck |
|
Build failed.
|
|
Resolved in 317 - sorry for the lag @Andersson007! |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Apr 22, 2022
Resolve black and sanity errors SUMMARY Add sanity ignore for ansible 2.14 and upgrade black version ISSUE TYPE Bugfix Pull Request COMPONENT NAME tox.ini tests/ignores/sanity-2.14.txt This would supersede #313 and #314 ADDITIONAL INFO Versions of black newer than 19.x introduce formatting changes that will need to be incorporated into the generated modules before we can check against those versions in CI https://black.readthedocs.io/en/stable/change_log.html#id61 Changes in click require black>=22.3.0. psf/black#2964 For now let's pin both at what works.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ansible-collections/news-for-maintainers#13
Dear maintainers,
I'd like to ask you to track the news-for-maintainers themselves in the future if possible
Thanks!