vmware_dvs_portgroup : Remove defaults and add explicit inheritance from switch defaults #1483
Conversation
mariolenz
added
WIP
mariolenz
changed the title
mariolenz
force-pushed
the
issue1316
branch
2 times, most recently
from
2ef2f9d to
6ad70f5
Compare
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 06s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 13s |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 16s |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 15s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 5m 11s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 10s |
|
recheck |
|
Build failed. ❌ ansible-tox-linters FAILURE in 6m 02s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 5m 04s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 55s |
|
recheck |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 06s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 06s |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 6m 02s |
|
@Nina2244 This PR might be interesting for you. I think that you use (or, a least, you've worked on) I want to allow users to keep some settings as they are when not defining a parameter, Additionally, users should be able to explicitly define some settings as inherited from the switch. |
mariolenz
changed the title
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 4m 28s |
Update changelog fragments for a better porting guide SUMMARY Update changelog fragments for a better porting guide ISSUE TYPE Docs Pull Request COMPONENT NAME vsphere_copy vmware_dns_config vmware_dvs_portgroup vmware_guest_boot_manager vmware_guest_network vmware_guest_vnc vmware_host_firewall_manager ADDITIONAL INFORMATION #1456 #1455 #1483 #1461 #1459 #1454 #1463
SUMMARY
Apart from the things that are specific to a portgroup (like, for example, its name) there are a lot of settings that could either be inherited from the switch or defined at the PG level.
Most, if not all, parameters of the module don't allow this: They have defaults which means the settings from the switch are always overwritten. Or they implicitly set something to inherited if the parameter is unset. This is a problem because people can't use the module in a way of "I don't care about this setting, just leave it as it is" manner or explicitly state that this setting should be inherited.
ISSUE TYPE
COMPONENT NAME
vmware_dvs_portgroup
ADDITIONAL INFORMATION
#1316