vmware_guest_network: Remove deprecated parameter networks #1459

mariolenz · 2022-09-12T17:48:25Z

SUMMARY

Fixes #1195

The networks parameter is deprecated and should be removed.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

vmware_guest_network

ADDITIONAL INFORMATION

community.vmware/plugins/modules/vmware_guest_network.py

Lines 865 to 871 in 67b9506

    
           if module.params['networks']: 
        
               network_data = {} 
        
               module.deprecate( 
        
                   msg='The old way of configuring interfaces by supplying an arbitrary list will be removed, loops should be used to handle multiple interfaces', 
        
                   version='3.0.0', 
        
                   collection_name='community.vmware' 
        
               )

softwarefactory-project-zuul · 2022-09-12T21:10:23Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 4m 37s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 53s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 51s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 50s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 27s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 27s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 23m 07s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 19m 17s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 28m 40s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 46m 26s
✔️ ansible-galaxy-importer SUCCESS in 4m 13s

softwarefactory-project-zuul · 2022-09-13T15:33:23Z

Build failed.

❌ ansible-tox-linters FAILURE in 6m 25s
✔️ build-ansible-collection SUCCESS in 5m 17s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 14s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 9m 25s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 9m 33s
❌ ansible-test-sanity-docker-stable-2.13 FAILURE in 10m 16s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 7m 31s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 19m 04s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 20m 50s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 30m 46s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 45m 38s
✔️ ansible-galaxy-importer SUCCESS in 5m 16s

softwarefactory-project-zuul · 2022-09-13T16:38:40Z

Build failed.

softwarefactory-project-zuul · 2022-09-14T14:46:14Z

Build failed.

mariolenz · 2022-09-14T14:50:27Z

recheck

softwarefactory-project-zuul · 2022-09-14T16:24:05Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 4m 22s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 49s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 13s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 54s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 19m 51s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 23m 23s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 27m 14s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 46m 43s
✔️ ansible-galaxy-importer SUCCESS in 4m 22s

softwarefactory-project-zuul · 2022-09-14T22:23:05Z

Build failed.

mariolenz · 2022-09-15T05:10:22Z

recheck

softwarefactory-project-zuul · 2022-09-15T09:58:22Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 4m 11s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 26s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 51s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 32s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 42s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 7m 51s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 18m 47s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 18m 13s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 28m 00s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 RETRY_LIMIT in 1h 07m 31s
✔️ ansible-galaxy-importer SUCCESS in 4m 23s

softwarefactory-project-zuul · 2022-09-15T13:09:36Z

Build failed.

mariolenz · 2022-09-15T13:13:13Z

recheck

softwarefactory-project-zuul · 2022-09-15T15:52:27Z

Build failed.

softwarefactory-project-zuul · 2022-09-15T16:53:28Z

Build failed.

softwarefactory-project-zuul · 2022-09-16T07:42:33Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 4m 18s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 41s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 09s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 05s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 20m 28s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable212 FAILURE in 19m 04s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 26m 38s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 48m 06s
✔️ ansible-galaxy-importer SUCCESS in 3m 56s

softwarefactory-project-zuul · 2022-09-16T15:14:41Z

Build failed.

mariolenz · 2022-09-16T15:28:33Z

recheck

softwarefactory-project-zuul · 2022-09-16T19:33:47Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 4m 24s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 14s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 26s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 49s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 57s
❌ ansible-test-cloud-integration-vcenter7_only-stable212 RETRY_LIMIT in 1h 00m 49s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable212 RETRY_LIMIT in 1h 01m 09s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 27m 38s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 16m 48s
✔️ ansible-galaxy-importer SUCCESS in 4m 38s

softwarefactory-project-zuul · 2022-09-17T06:59:02Z

Build failed.

softwarefactory-project-zuul · 2022-09-17T12:21:39Z

Build failed.

mariolenz · 2022-09-17T12:25:57Z

recheck

softwarefactory-project-zuul · 2022-09-17T14:25:31Z

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 4m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 21s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 22s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 37s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 58s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 07s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 15s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable212 FAILURE in 20m 09s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 28m 52s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 14m 04s
✔️ ansible-galaxy-importer SUCCESS in 4m 09s

softwarefactory-project-zuul · 2022-09-17T18:14:51Z

Build failed.

mariolenz · 2022-09-17T20:11:00Z

recheck

softwarefactory-project-zuul · 2022-09-17T22:30:36Z

Build succeeded.

softwarefactory-project-zuul · 2022-09-18T04:47:59Z

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 3m 30s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 17s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 37s
✔️ ansible-galaxy-importer SUCCESS in 4m 11s

Update changelog fragments for a better porting guide SUMMARY Update changelog fragments for a better porting guide ISSUE TYPE Docs Pull Request COMPONENT NAME vsphere_copy vmware_dns_config vmware_dvs_portgroup vmware_guest_boot_manager vmware_guest_network vmware_guest_vnc vmware_host_firewall_manager ADDITIONAL INFORMATION #1456 #1455 #1483 #1461 #1459 #1454 #1463

mariolenz added the WIP Work in progress label Sep 12, 2022

mariolenz force-pushed the issue1195 branch from 2118436 to 0f4e991 Compare September 13, 2022 13:27

mariolenz force-pushed the issue1195 branch from 0f4e991 to 0284a9a Compare September 13, 2022 15:41

mariolenz force-pushed the issue1195 branch from 0284a9a to bb45375 Compare September 14, 2022 11:36

mariolenz force-pushed the issue1195 branch from bb45375 to 9a5ada2 Compare September 14, 2022 20:21

mariolenz force-pushed the issue1195 branch from 9a5ada2 to c7983cd Compare September 15, 2022 11:38

mariolenz closed this Sep 15, 2022

mariolenz reopened this Sep 15, 2022

mariolenz force-pushed the issue1195 branch from c7983cd to 4c77d05 Compare September 16, 2022 04:50

mariolenz force-pushed the issue1195 branch from 4c77d05 to 1e251a7 Compare September 16, 2022 13:48

mariolenz force-pushed the issue1195 branch from 1e251a7 to 6de892b Compare September 16, 2022 16:24

mariolenz force-pushed the issue1195 branch from 6de892b to 535e8b0 Compare September 17, 2022 05:31

mariolenz force-pushed the issue1195 branch from 535e8b0 to 7b86c1f Compare September 17, 2022 10:52

mariolenz force-pushed the issue1195 branch from 7b86c1f to 96281b0 Compare September 17, 2022 13:50

vmware_guest_network: Remove deprecated parameter networks

4ca10d5

mariolenz force-pushed the issue1195 branch from 96281b0 to 4ca10d5 Compare September 17, 2022 14:31

mariolenz closed this Sep 17, 2022

mariolenz reopened this Sep 17, 2022

mariolenz changed the title ~~[WIP] vmware_guest_network: Remove deprecated parameter networks~~ vmware_guest_network: Remove deprecated parameter networks Sep 18, 2022

mariolenz added mergeit and removed WIP Work in progress labels Sep 18, 2022

softwarefactory-project-zuul bot merged commit ce764aa into ansible-collections:main Sep 18, 2022

mariolenz deleted the issue1195 branch September 18, 2022 05:00

mariolenz mentioned this pull request Oct 9, 2022

Update changelog fragments for a better porting guide #1490

Merged

renovate bot mentioned this pull request Oct 10, 2022

Update dependency community.vmware to v3 - autoclosed Fredouye/argocd#11

Closed

1 task

slauger mentioned this pull request Oct 11, 2022

fix(deps): update galaxy-collection dependency community.vmware to v3 - autoclosed slauger/openshift-sdk#60

Closed

1 task

slauger mentioned this pull request Oct 24, 2022

fix(deps): update galaxy-collection dependency community.vmware to v3 - autoclosed slauger/openshift-sdk#68

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vmware_guest_network: Remove deprecated parameter networks #1459

vmware_guest_network: Remove deprecated parameter networks #1459

mariolenz commented Sep 12, 2022

softwarefactory-project-zuul bot commented Sep 12, 2022

softwarefactory-project-zuul bot commented Sep 13, 2022

softwarefactory-project-zuul bot commented Sep 13, 2022

softwarefactory-project-zuul bot commented Sep 14, 2022

mariolenz commented Sep 14, 2022

softwarefactory-project-zuul bot commented Sep 14, 2022

softwarefactory-project-zuul bot commented Sep 14, 2022

mariolenz commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

mariolenz commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 16, 2022

softwarefactory-project-zuul bot commented Sep 16, 2022

mariolenz commented Sep 16, 2022

softwarefactory-project-zuul bot commented Sep 16, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

mariolenz commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

mariolenz commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 18, 2022

	if module.params['networks']:
	network_data = {}
	module.deprecate(
	msg='The old way of configuring interfaces by supplying an arbitrary list will be removed, loops should be used to handle multiple interfaces',
	version='3.0.0',
	collection_name='community.vmware'
	)

vmware_guest_network: Remove deprecated parameter networks #1459

vmware_guest_network: Remove deprecated parameter networks #1459

Conversation

mariolenz commented Sep 12, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Sep 12, 2022

softwarefactory-project-zuul bot commented Sep 13, 2022

softwarefactory-project-zuul bot commented Sep 13, 2022

softwarefactory-project-zuul bot commented Sep 14, 2022

mariolenz commented Sep 14, 2022

softwarefactory-project-zuul bot commented Sep 14, 2022

softwarefactory-project-zuul bot commented Sep 14, 2022

mariolenz commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

mariolenz commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 16, 2022

softwarefactory-project-zuul bot commented Sep 16, 2022

mariolenz commented Sep 16, 2022

softwarefactory-project-zuul bot commented Sep 16, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

mariolenz commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

mariolenz commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 17, 2022

softwarefactory-project-zuul bot commented Sep 18, 2022